Skip to content

Append duplicate parameter values without copying prior arrays #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OskarEichler wants to merge 2 commits into
base: main
Choose a base branch
from
+8 −1
Open

Append duplicate parameter values without copying prior arrays #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c11856
Append duplicate parameter values without copying prior arrays
OskarEichler Aug 28, 2026
547f5c6
Add parser regression coverage
OskarEichler Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/websocket/extensions/parser.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,8 @@ def self.parse_header(header)
end

if offer.has_key?(key)
offer[key] = [*offer[key]] + [data]
offer[key] = [offer[key]] unless offer[key].is_a?(Array)
offer[key].push(data)
else
offer[key] = data
end
Expand Down
6 changes: 6 additions & 0 deletions spec/websocket/extensions/parser_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,12 @@ def parse(string)
]
end

it "preserves more than two duplicate params in order" do
expect(parse "a; b=1; b=2; b=3").to eq [
{ :name => "a", :params => { "b" => [1, 2, 3] } }
]
end

it "parses multiple complex offers" do
expect(parse 'a; b=1, c, b; d, c; e="hi, there"; e, a; b').to eq [
{ :name => "a", :params => { "b" => 1 } },
Expand Down