Append duplicate parameter values without copying prior arrays - #10
Open
OskarEichler wants to merge 1 commit into
Open
Append duplicate parameter values without copying prior arrays#10OskarEichler wants to merge 1 commit into
OskarEichler wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Append duplicate parameter values to their existing array instead of allocating and copying the accumulated array on every occurrence.
Reproduction and verification
1,000 ordered duplicate values verified. In a paired cumulative-parser benchmark, a 1,000-parameter header fell from about 8,013 to 5,017 allocations and 0.961 to 0.594 ms per parse. The exact timings include other verified parser corrections; the isolated source change removes repeated prior-array copies.
Breaking changes and limitations
No intended breaking change. Parameter order, values and single-value representation are unchanged; arrays are owned by this parse, not supplied by callers.
Only local Ruby 4.0.6/macOS execution is claimed; the repository's older Ruby/JRuby matrix needs upstream CI. No production access or unrelated release upgrades.