Skip to content

fix: stop accumulating DIP rewards after risk bundle is closed/burned #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VQToan wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix: stop accumulating DIP rewards after risk bundle is closed/burned #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions contracts/DepegRiskpool.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import "@etherisc/gif-interface/contracts/tokens/IBundleToken.sol";
import "./gif/BasicRiskpool2.sol";
import "./registry/IChainRegistryFacade.sol";
import "./staking/IStakingFacade.sol";
import "./staking/IStakingFacadeExt.sol";


contract DepegRiskpool is
Expand Down Expand Up @@ -752,6 +753,32 @@ contract DepegRiskpool is
}


function _afterCloseBundle(uint256 bundleId) internal override virtual {
super._afterCloseBundle(bundleId);

// stop reward accumulation for closed bundle
if (address(_staking) != address(0)) {
uint96 nftId = getNftId(bundleId);
if (nftId > 0) {
// IStakingFacadeExt required to call setTargetRewardRate
try IStakingFacadeExt(address(_staking)).setTargetRewardRate(nftId, 0) {} catch {}
}
}
}

function _afterBurnBundle(uint256 bundleId) internal override virtual {
super._afterBurnBundle(bundleId);

// stop reward accumulation for burned bundle (just to be safe if not already closed)
if (address(_staking) != address(0)) {
uint96 nftId = getNftId(bundleId);
if (nftId > 0) {
// IStakingFacadeExt required to call setTargetRewardRate
try IStakingFacadeExt(address(_staking)).setTargetRewardRate(nftId, 0) {} catch {}
}
}
}

function _getBundleApr(uint256 bundleId) internal view returns (uint256 annualPercentageReturn) {
bytes memory filter = getBundleFilter(bundleId);
(,,,,,, annualPercentageReturn) = decodeBundleParamsFromFilter(filter);
Expand Down