fix: stop accumulating DIP rewards after risk bundle is closed/burned - #39
Open
VQToan wants to merge 1 commit into
Open
fix: stop accumulating DIP rewards after risk bundle is closed/burned#39VQToan wants to merge 1 commit into
VQToan wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #31
Description
Prevents DIP rewards from accumulating after a risk bundle is closed or burned. Currently, stakers continue to accrue rewards even after the risk bundle is inactive, leading to incorrect reward distribution.
Changes
_afterCloseBundleand_afterBurnBundleinDepegRiskpool.solto hook into bundle state transitions.setTargetRewardRate(nftId, 0)on the staking facade when the bundle is closed or burned, stopping further DIP reward accrual.IStakingFacadeExt.solto include thesetTargetRewardRatemethod definition so it can be called correctly.This PR was created with AI assistance.