-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Use direct URLs for test resources #7663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ericstj
wants to merge
2
commits into
dotnet:main
Choose a base branch
from
ericstj:fix/direct-test-resource-urls
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+88
−52
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
64 changes: 64 additions & 0 deletions
64
test/Microsoft.ML.TestFrameworkCommon/TestDownloadUtils.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
| // See the LICENSE file in the project root for more information. | ||
|
|
||
| using System; | ||
| using System.IO; | ||
| using System.Net.Http; | ||
| using System.Threading; | ||
| using System.Threading.Tasks; | ||
|
|
||
| namespace Microsoft.ML.TestFrameworkCommon | ||
| { | ||
| public static class TestDownloadUtils | ||
| { | ||
| public static void DownloadFile(string url, string filePath, TimeSpan timeout) | ||
| { | ||
| var directory = Path.GetDirectoryName(filePath); | ||
| if (!string.IsNullOrEmpty(directory)) | ||
| Directory.CreateDirectory(directory); | ||
|
|
||
| string temporaryFilePath = $"{filePath}.{Guid.NewGuid():N}.download"; | ||
| using (var client = new HttpClient { Timeout = Timeout.InfiniteTimeSpan }) | ||
| { | ||
| RetryHelper.Execute(() => | ||
| { | ||
| try | ||
| { | ||
| if (File.Exists(filePath)) | ||
| return; | ||
|
|
||
| using (var cancellationSource = new CancellationTokenSource(timeout)) | ||
| using (var response = client.GetAsync(url, HttpCompletionOption.ResponseHeadersRead, cancellationSource.Token).GetAwaiter().GetResult()) | ||
| { | ||
| response.EnsureSuccessStatusCode(); | ||
| long? expectedLength = response.Content.Headers.ContentLength; | ||
| using (var contentStream = response.Content.ReadAsStreamAsync().GetAwaiter().GetResult()) | ||
| using (var fileStream = new FileStream(temporaryFilePath, FileMode.Create, FileAccess.Write, FileShare.None)) | ||
| { | ||
| contentStream.CopyToAsync(fileStream, 81920, cancellationSource.Token).GetAwaiter().GetResult(); | ||
| if (expectedLength.HasValue && fileStream.Length != expectedLength.Value) | ||
| throw new IOException($"Expected {expectedLength.Value} bytes from '{url}', but downloaded {fileStream.Length} bytes."); | ||
| } | ||
| } | ||
|
|
||
| try | ||
| { | ||
| File.Move(temporaryFilePath, filePath); | ||
| } | ||
| catch (IOException) when (File.Exists(filePath)) | ||
| { | ||
| // Another caller completed the same download first. | ||
| } | ||
| } | ||
| finally | ||
| { | ||
| if (File.Exists(temporaryFilePath)) | ||
| File.Delete(temporaryFilePath); | ||
| } | ||
| }, backoffFunc: attempt => 10_000, | ||
| retryWhen: ex => ex is HttpRequestException || ex is TaskCanceledException || ex is IOException); | ||
| } | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking forward, do you think we might need to handle servicing release branches or is that not a concern in ML.NET? Just wondering if by taking data from
mainbranch we might hit an issue later. Note, I haven't onboarded into the full release process so maybe this is not an issue at all.