fix: implement replace_children on distributed plan nodes - #658
Closed
shinzoxD wants to merge 13 commits into
Closed
fix: implement replace_children on distributed plan nodes#658shinzoxD wants to merge 13 commits into
shinzoxD wants to merge 13 commits into
Conversation
Co-authored-by: Gabriel <45515538+gabotechs@users.noreply.github.com>
…distributed into branch-55
shinzoxD
changed the title
Contributor
Author
|
Recreating as a non-draft PR targeting branch-55. |
jayshrivastava
force-pushed
the
branch-55
branch
from
August 19, 2026 21:41
300b5af to
e114458
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #657
Depends on #540 (DataFusion 55).
with_new_childrenis deprecated in favor ofreplace_children.Implement
replace_childrenon our customExecutionPlannodes.with_new_childrenstill works and forwardsChildrenPropertiesMode::Recompute.Nodes:
BroadcastExec,SamplerExec,DistributedLeafExec,MetricsWrapperExec,ChildrenIsolatorUnionExecNetworkBroadcastExec,NetworkCoalesceExec,NetworkShuffleExecDistributedExec,DistributedAnalyzeExecMockExec,URLEmitterExec,RowGeneratorExec