fix: implement replace_children on distributed plan nodes - #668
Closed
shinzoxD wants to merge 2 commits into
Closed
Conversation
Contributor
Author
|
CI fix pushed: clippy: unit-test
Left the test alone: fixing the 4-task LIMIT shape is #624, which this PR should not mix in. If unit-test is red again on this SHA, treat it as that pre-existing flake rather than a Did not undraft or merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #657
ExecutionPlan::replace_childrenis a DataFusion 55 API.branch-55was merged tomainin #540 (v4.0.0), so this targetsmain.with_new_childrenis deprecated in favor ofreplace_children. This implementsreplace_childrenon our custom plan nodes. Existingwith_new_childrencallers keep working; they forwardChildrenPropertiesMode::Recompute.Types:
BroadcastExec,SamplerExec,DistributedLeafExec,MetricsWrapperExec,ChildrenIsolatorUnionExecNetworkBroadcastExec,NetworkCoalesceExec,NetworkShuffleExecDistributedExec,DistributedAnalyzeExecMockExec,URLEmitterExec,RowGeneratorExecReplaces closed draft #658.