Skip to content

412 [SPARQL] Validate operand types in expressions#464

Merged
remiceres merged 5 commits into
feature/corese-nextfrom
feature/412-sparql-validate-operand-types-in-expressions
Jun 24, 2026
Merged

412 [SPARQL] Validate operand types in expressions#464
remiceres merged 5 commits into
feature/corese-nextfrom
feature/412-sparql-validate-operand-types-in-expressions

Conversation

@MaillPierre

Copy link
Copy Markdown
Contributor

Adds checks on functions that will only accept numerics an booleans. Other types can be assumed to be string if reduced to their lexical values.
The argument count is already checked during the parsing step.

@MaillPierre MaillPierre self-assigned this Jun 18, 2026
@MaillPierre MaillPierre added the Refactoring Issue created during the 2025 refactoring effort label Jun 18, 2026
@MaillPierre MaillPierre linked an issue Jun 18, 2026 that may be closed by this pull request
@github-actions

Copy link
Copy Markdown
Overall Project 48.83% -0.01% 🍏
Files changed 94.54% 🍏

File Coverage
OperandArgumentIRITypeValidationRule.java 100% 🍏
OperandArgumentBooleanTypeValidationRule.java 100% 🍏
SemanticValidationUtils.java 93.05% -6.95% 🍏
SparqlQuerySemanticValidator.java 92.06% 🍏
OperandArgumentNumericTypeValidationRule.java 89.6% -10.4% 🍏
FilterArgumentsValidationRule.java 87.06% 🍏
UpdateRequestAst.java 82.22% 🍏
StrUuidAst.java 77.78% 🍏
UuidAst.java 77.78% 🍏
ConcatAst.java 66.67% 🍏
SameTermAst.java 53.33% 🍏
StrLenAst.java 40% 🍏

@github-actions

github-actions Bot commented Jun 18, 2026

Copy link
Copy Markdown

Test Results

  422 files    422 suites   20s ⏱️
2 377 tests 2 377 ✅ 0 💤 0 ❌
2 391 runs  2 391 ✅ 0 💤 0 ❌

Results for commit 1c527e1.

♻️ This comment has been updated with latest results.

@MaillPierre MaillPierre force-pushed the feature/412-sparql-validate-operand-types-in-expressions branch from a478a75 to a194b80 Compare June 22, 2026 08:23
@github-actions

Copy link
Copy Markdown
Overall Project 49.02% -0.01% 🍏
Files changed 94.54% 🍏

File Coverage
OperandArgumentIRITypeValidationRule.java 100% 🍏
OperandArgumentBooleanTypeValidationRule.java 100% 🍏
SparqlQuerySemanticValidator.java 95.58% 🍏
SemanticValidationUtils.java 93.05% -6.95% 🍏
OperandArgumentNumericTypeValidationRule.java 89.6% -10.4% 🍏
FilterArgumentsValidationRule.java 87.06% 🍏
UpdateRequestAst.java 82.22% 🍏
StrUuidAst.java 77.78% 🍏
UuidAst.java 77.78% 🍏
ConcatAst.java 66.67% 🍏
SameTermAst.java 53.33% 🍏
StrLenAst.java 40% 🍏

@github-actions

Copy link
Copy Markdown
Overall Project 49.06% -0.01% 🍏
Files changed 95.19% 🍏

File Coverage
OperandArgumentIRITypeValidationRule.java 100% 🍏
OperandArgumentBooleanTypeValidationRule.java 100% 🍏
SparqlQuerySemanticValidator.java 95.58% 🍏
SemanticValidationUtils.java 94.28% -5.72% 🍏
OperandArgumentNumericTypeValidationRule.java 89.6% -10.4% 🍏
FilterArgumentsValidationRule.java 87.06% 🍏
UpdateRequestAst.java 82.22% 🍏
StrUuidAst.java 77.78% 🍏
UuidAst.java 77.78% 🍏
ConcatAst.java 66.67% 🍏
SameTermAst.java 53.33% 🍏
StrLenAst.java 40% 🍏

@MaillPierre MaillPierre force-pushed the feature/412-sparql-validate-operand-types-in-expressions branch from e6c65f2 to 32d9089 Compare June 24, 2026 09:06
@MaillPierre MaillPierre requested a review from remiceres June 24, 2026 09:09
@github-actions

Copy link
Copy Markdown
Overall Project 49.06% -0.01% 🍏
Files changed 95.19% 🍏

File Coverage
OperandArgumentIRITypeValidationRule.java 100% 🍏
OperandArgumentBooleanTypeValidationRule.java 100% 🍏
SparqlQuerySemanticValidator.java 95.58% 🍏
SemanticValidationUtils.java 94.28% -5.72% 🍏
OperandArgumentNumericTypeValidationRule.java 89.6% -10.4% 🍏
FilterArgumentsValidationRule.java 87.06% 🍏
UpdateRequestAst.java 82.22% 🍏
StrUuidAst.java 77.78% 🍏
UuidAst.java 77.78% 🍏
ConcatAst.java 66.67% 🍏
SameTermAst.java 53.33% 🍏
StrLenAst.java 40% 🍏

@github-actions

Copy link
Copy Markdown
Overall Project 49.06% -0.01% 🍏
Files changed 95.17% 🍏

File Coverage
OperandArgumentIRITypeValidationRule.java 100% 🍏
OperandArgumentBooleanTypeValidationRule.java 100% 🍏
ConcatAst.java 100% 🍏
SparqlQuerySemanticValidator.java 95.58% 🍏
SemanticValidationUtils.java 94.23% -5.77% 🍏
OperandArgumentNumericTypeValidationRule.java 89.6% -10.4% 🍏
FilterArgumentsValidationRule.java 87.06% 🍏
UpdateRequestAst.java 82.22% 🍏
StrUuidAst.java 77.78% 🍏
UuidAst.java 77.78% 🍏
SameTermAst.java 53.33% 🍏
StrLenAst.java 40% 🍏

@remiceres remiceres merged commit d4763ef into feature/corese-next Jun 24, 2026
2 checks passed
@remiceres remiceres deleted the feature/412-sparql-validate-operand-types-in-expressions branch June 24, 2026 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Refactoring Issue created during the 2025 refactoring effort

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[SPARQL] Validate operand types in expressions

3 participants