fix(codegen): include partition keys in ORM update/delete mutations#1295
Merged
Conversation
PostGraphile adds extra required fields (e.g. databaseId) to the
update/delete mutation inputs for partitioned tables. The ORM codegen
was only emitting { id, patch } for updates and { id } for deletes,
causing GraphQL validation errors at runtime.
Changes:
- query-builder template: buildUpdateByPkDocument accepts optional
extraKeys param, spread into the input variables
- model-generator: introspects UpdateInput/DeleteInput types via
typeRegistry to discover extra required fields beyond PK + patch
- Extra keys are added to the where type (TypeScript) and included
in the runtime mutation variables
- generateAllModelFiles now receives typeRegistry from orchestrator
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PostGraphile adds extra required fields to update/delete mutation inputs for partitioned tables (e.g.
databaseIdas partition key). The ORM codegen was only emitting{ id, patch }for updates and{ id }for deletes, causing runtime GraphQL validation errors:Fix: At codegen time, introspect
UpdateXxxInput/DeleteXxxInputtypes viatypeRegistryto discover required fields beyondclientMutationId+ PK + patch. These "extra keys" (e.g.databaseId) are:Added to the
wheretype so callers must provide them:Included in the runtime mutation variables via a new
extraKeysparam onbuildUpdateByPkDocument:For
buildDeleteByPkDocument, extra keys are merged into the existingkeysobject (already aRecord<string, unknown>).When
typeRegistryis unavailable (e.g. file-based codegen without introspection), behavior is unchanged — no extra keys are discovered.Link to Devin session: https://app.devin.ai/sessions/b2291a8e333e445aa125a2efd1996206
Requested by: @pyramation