fix(codegen): include partition keys in hooks update/delete mutation variables#1296
Merged
Conversation
…variables Extracts getExtraInputKeys to shared utils, applies to both ORM model-generator and React Query mutation hooks. Update/delete hooks now include extra required fields (e.g. databaseId for partitioned tables) in the variable type, destructured params, and ORM where clause.
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends the partition key fix from PR #1295 (ORM model generator) to also cover React Query mutation hooks.
Previously,
generateUpdateMutationHookandgenerateDeleteMutationHookonly included the primary key field in the mutation variable type. For partitioned tables (e.g. those withdatabaseId), the generated hooks would produce type errors because the ORM'swheretype now requires the extra keys.Changes:
Extracted
getExtraInputKeysto sharedutils.ts— was previously a private function inmodel-generator.ts. Both ORM and hooks generators now import from the same source.mutations.ts—generateUpdateMutationHook: discovers extra required fields viatypeRegistry, adds them toupdateVarType, the destructured arrow param, and the ORM.whereobject.mutations.ts—generateDeleteMutationHook: same treatment — extra keys appear indeleteVarType, destructured param, and.where.MutationGeneratorOptionsgainstypeRegistry?: TypeRegistry, threaded fromindex.tsviacustomOperations.typeRegistry.// Before (generated hook): mutate({ id: 'abc' }) // → Error: databaseId is required // After: mutate({ id: 'abc', databaseId: 'xyz' }) // → worksLink to Devin session: https://app.devin.ai/sessions/b2291a8e333e445aa125a2efd1996206
Requested by: @pyramation