Skip to content

feat: Add new methods doubleClick and scrollIntoView - #243

Open
jperals wants to merge 6 commits into
mainfrom
feat/scroll-into-view
Open

feat: Add new methods doubleClick and scrollIntoView#243
jperals wants to merge 6 commits into
mainfrom
feat/scroll-into-view

Conversation

@jperals

@jperals jperals commented Jul 31, 2026

Copy link
Copy Markdown
Member
  • Add two new methods so that they can be used everywhere without duplication
  • Added tests for the new two methods
  • Refactor tests so that methods belonging to the base page object are tested for this class and not for child classes

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jperals jperals changed the title Feat/scroll into view feat: Add new methods doubleClick and scrollIntoView Jul 31, 2026
@@ -0,0 +1,348 @@
// Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the tests for the two new methods, the rest are moved from screenshot-page-object.test.ts.

I think it makes more sense to test them on the base class (which is used directly in many integration tests) than on child classes.

@codecov

codecov Bot commented Jul 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.15%. Comparing base (0ff0098) to head (d296dac).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #243      +/-   ##
==========================================
+ Coverage   93.06%   93.15%   +0.08%     
==========================================
  Files          20       20              
  Lines         476      482       +6     
  Branches       84       84              
==========================================
+ Hits          443      449       +6     
  Misses         29       29              
  Partials        4        4              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jperals
jperals marked this pull request as ready for review July 31, 2026 06:31
@jperals
jperals requested a review from a team as a code owner July 31, 2026 06:31
@jperals
jperals requested review from pan-kot and removed request for a team July 31, 2026 06:31
@jperals
jperals enabled auto-merge July 31, 2026 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant