chore: Add visual tests for more components (C-E) - #4833
Open
jperals wants to merge 14 commits into
Open
Conversation
jperals
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4833 +/- ##
=======================================
Coverage 97.63% 97.63%
=======================================
Files 957 957
Lines 31097 31097
Branches 11434 11434
=======================================
Hits 30361 30361
Misses 729 729
Partials 7 7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jperals
force-pushed
the
dev-v3-jotresse-test-definitions-04
branch
from
July 30, 2026 16:05
432b07c to
bed45f1
Compare
jperals
marked this pull request as ready for review
July 31, 2026 08:36
jperals
enabled auto-merge
July 31, 2026 08:36
jperals
commented
Jul 31, 2026
| await this.waitForJsTimers(500); | ||
| } | ||
|
|
||
| async doubleClick(selector: string): Promise<void> { |
Member
Author
There was a problem hiding this comment.
These two methods can be removed after this is released: cloudscape-design/browser-test-tools#243
jperals
commented
Jul 31, 2026
| description: 'Z-index', | ||
| tests: [ | ||
| ...[600, 1280].flatMap(width => [ | ||
| ...[600, 1280].flatMap<TestDefinition>(width => [ |
Member
Author
There was a problem hiding this comment.
Small refactor as follow-up from #4826 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ticket:
D417180663Related:
CR-293462594Note: excludes code editor for the time being because of issues with CSP. It is also excluded from
CR-293462594, so it will still be run internally.How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.