Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/bright-browsers-recycle.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"agents": patch
---

Recycle reusable Browser Run sessions after the platform reports HTTP 410 for an expired session.
6 changes: 5 additions & 1 deletion packages/agents/src/browser/connector.ts
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,11 @@ const EXEC_TOUCH_INTERVAL_MS = 60 * 1000;
const LIVE_VIEW_URL_TTL_MS = 5 * 60 * 1000;

function isMissingBrowserSession(error: unknown): boolean {
return error instanceof BrowserRenderingError && error.status === 404;
// Browser Run uses 404 for unknown ids and 410 after keep_alive expiry.
return (
error instanceof BrowserRenderingError &&
(error.status === 404 || error.status === 410)
);
}

/**
Expand Down
80 changes: 80 additions & 0 deletions packages/agents/src/tests/browser-connector.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -613,6 +613,86 @@ describe("BrowserConnector", () => {
expect(deletesFor(requests, "session-1")).toHaveLength(1);
});

it.each([404, 410])(
"recycles a shared session when Browser Run returns %i",
async (status) => {
const { browser, requests } = createFakeBrowser({
listStatuses: [status]
});
const store = new MemorySessionStore();
store.set("cdp:reuse:team", {
sessionId: "session-expired",
createdAt: Date.now(),
updatedAt: Date.now()
});
const connector = new BrowserConnector(fakeCtx, {
browser,
store,
session: { mode: "reuse", key: "team" }
});

await expect(
connector.executeTool(
"send",
{ method: "Browser.getVersion" },
{ executionId: "exec-a" }
)
).resolves.toEqual({ echo: "Browser.getVersion" });

expect(store.sessions.get("cdp:reuse:team")?.sessionId).toBe("session-1");
expect(
requests.filter((request) => request.method === "POST")
).toHaveLength(1);
}
);

it("clears an expired shared session from sessionInfo on HTTP 410", async () => {
const { browser } = createFakeBrowser({ listStatuses: [410] });
const store = new MemorySessionStore();
store.set("cdp:reuse:default", {
sessionId: "session-expired",
createdAt: Date.now(),
updatedAt: Date.now()
});
const connector = new BrowserConnector(fakeCtx, {
browser,
store,
session: { mode: "reuse" }
});

await expect(connector.sessionInfo()).resolves.toBeUndefined();
expect(store.sessions.has("cdp:reuse:default")).toBe(false);
});

it("does not recycle a shared session on other Browser Run errors", async () => {
const { browser, requests } = createFakeBrowser({ listStatuses: [500] });
const store = new MemorySessionStore();
store.set("cdp:reuse:default", {
sessionId: "session-unavailable",
createdAt: Date.now(),
updatedAt: Date.now()
});
const connector = new BrowserConnector(fakeCtx, {
browser,
store,
session: { mode: "reuse" }
});

await expect(
connector.executeTool(
"send",
{ method: "Browser.getVersion" },
{ executionId: "exec-a" }
)
).rejects.toThrow("500");
expect(store.sessions.get("cdp:reuse:default")?.sessionId).toBe(
"session-unavailable"
);
expect(
requests.filter((request) => request.method === "POST")
).toHaveLength(0);
});

it("shares one stored session across executions in reuse mode", async () => {
const { browser, requests } = createFakeBrowser();
const store = new MemorySessionStore();
Expand Down
Loading