fix: recycle Browser Run sessions on HTTP 410#1981
Open
agent-think[bot] wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: f778708 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
agents
@cloudflare/ai-chat
@cloudflare/codemode
create-think
hono-agents
@cloudflare/shell
@cloudflare/think
@cloudflare/voice
@cloudflare/worker-bundler
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1980.
What changed
410 Goneas a missing/expired session, alongside404500sessionInfo()cleanupBrowser Run status validation
I deployed a temporary Browser Run probe and called the binding directly. It confirmed:
GET /v1/devtools/browser/<expired-session>/json/listreturns 410 with{"error":"Failed to list targets: 410"}afterkeep_aliveexpiryDELETE /v1/devtools/browser/<expired-session>returns 404 with{"error":"Failed to delete browser session: 404"}This means connector liveness checks need to recognize both
404(unknown/deleted) and410(expired), while continuing to surface all other errors.Verification
BrowserRenderingError ... status: 410pnpm --filter agents exec vitest run --config src/tests/vitest.config.ts src/tests/browser-connector.test.ts— 34 passedpnpm run check— passed (all 117 TypeScript projects)pnpm run build— passed (25 projects)agentsbuild and deployed a temporary full-stack Browser Run demo; its API returnedpassed: truewith a new replacement session ID after the injected stale-session410Demo: https://issue-1980-browser-session-recycle.magnificent-supermarket.workers.dev