Consolidate crate_universe generated defs.bzl into crates.bzl#4094
Open
UebelAndre wants to merge 2 commits into
Open
Consolidate crate_universe generated defs.bzl into crates.bzl#4094UebelAndre wants to merge 2 commits into
defs.bzl into crates.bzl#4094UebelAndre wants to merge 2 commits into
Conversation
UebelAndre
force-pushed
the
crate_universe_pre
branch
from
3574555 to
2781831
Compare
UebelAndre
force-pushed
the
crate_universe_pre
branch
4 times, most recently
from
d882a2d to
afd8c74
Compare
UebelAndre
force-pushed
the
crate_universe_pre
branch
from
afd8c74 to
b62f218
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change begins to consolidate
defs.bzlintocrates.bzlso users don't get confused as to which of the two to use. In doing so, I have also consolidated the repository rules for where crate aliases are generated between thecratemodule extension and outputs tocrates_vendorrule as a cleanup and consolidation effort. In the future I plan to have that rule be responsible for aliases and the crate dependency interface.