Render crates into subpackages#4093
Draft
UebelAndre wants to merge 4 commits into
Draft
Conversation
Collaborator
Author
|
For reviewers, this change should be reviewed commit-by-commit. |
UebelAndre
force-pushed
the
crate_universe_cleanup
branch
4 times, most recently
from
0cd8255 to
a39dd65
Compare
UebelAndre
force-pushed
the
crate_universe_cleanup
branch
from
a39dd65 to
a800a19
Compare
UebelAndre
force-pushed
the
crate_universe_cleanup
branch
from
a800a19 to
f0e7a3d
Compare
Collaborator
Author
|
This change is being stacked on top of #4094 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
crate_universerenders aliases into a single package for developers to consume. The issue with this design is that for projects with massive amounts of dependencies, Bazel parsing that BUILD file can be slow and have noticable impacts on analysis. This change updatescrate_universeto render aliases into sub-packages instead of a root BUILD file in the repo hubs. In practice this means dependencies that were once accessed via@crate_index//:clapare now accessed via@crate_index//clap. Currently both root level aliases are still rendered but can be disabled via the newincompatible_no_root_alias_targetsflag.