Skip to content

chore: fix minor inconsistencies in API #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dkarwowski wants to merge 1 commit into
base: main
Choose a base branch
from
+19 −6
Open

chore: fix minor inconsistencies in API #60

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions connection-coordinator/schemas/connection.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,7 @@ Connection:
oneOf:
- $ref: "#/EncodedKey"
- $ref: "#/SourceConnectionName"


type: object
type: object

FeatureGuidance:
Expand Down Expand Up @@ -330,7 +329,6 @@ GenerateFeatureGuidanceResponse:
provisioned on.
items:
$ref: "#/FeatureGuidance"
readOnly: true
type: array
type: object

Expand All @@ -347,6 +345,7 @@ EncodedKey:
properties:
encodedKey:
type: string
type: object

SourceConnectionName:
description: |-
Expand All @@ -355,3 +354,4 @@ SourceConnectionName:
properties:
sourceConnectionName:
type: string
type: object
13 changes: 13 additions & 0 deletions connection-coordinator/schemas/feature.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,8 @@ FeatureConfig:
allOf:
- $ref: "#/L3BaseConfig"
description: All configuration associated with the FEATURE_TYPE_L3_BASE
required:
- featureType
type: object
L3BaseConfig:
description: All FEATURE_TYPE_L3_BASE configuration.
Expand Down Expand Up @@ -105,6 +107,13 @@ L3BaseConfig:
md5BgpPassword:
description: Shared MD5 password for BGP sessions.
type: string
required:
- ipv4Subnet

@bpescato-amazon bpescato-amazon Aug 12, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to force v4 as required but not v6?

- ipv4SubnetPrefixLength
- md5BgpPassword
- mtuBytes
- providerBgpConfigs
- vlanId
type: object
ProviderBgpConfig:
description: |-
Expand All @@ -130,6 +139,10 @@ ProviderBgpConfig:
hostIpv6:
description: Optional. IPv6 address hosting BGP session for provider.
type: string
required:
- asn
- hostIpv4

@bpescato-amazon bpescato-amazon Aug 12, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same v4 vs v6 question here.

- provider
type: object

ListFeaturesResponse:
Expand Down
1 change: 1 addition & 0 deletions connection-coordinator/schemas/macseckey.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ MacSecKey:
While `active=true`, this macSecKey cannot be deleted.
type: boolean
readOnly: true
type: object

ListMacSecKeysResponse:
description: Response for obtaining multiple MacSecKey resources
Expand Down
5 changes: 2 additions & 3 deletions connection-coordinator/schemas/provider.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,9 @@ Provider:
type: string
displayName:
description: |-
Output only. Provider name suitable for display to end users.
Provider name suitable for display to end users.

Example: Amazon Web Services, Google Cloud Platform, Microsoft Azure, etc
readOnly: true
type: string
type: object

Expand All @@ -58,7 +57,7 @@ ListProvidersResponse:
name: providers/my-provider
nextPageToken: nextPageToken
properties:
environments:
providers:
description: The providers known to the remote.
items:
$ref: "#/Provider"
Expand Down