chore: fix minor inconsistencies in API - #60
Open
dkarwowski wants to merge 1 commit into
Open
Conversation
dkarwowski
commented
Jul 31, 2026
dkarwowski
commented
Collaborator
- minimal set of required fields listed for features.
- remove readonly settings from responses.
- missing type on macsec keys.
- removing readonly from providers that have no post methods
- list providers should be a list of providers
dkarwowski
force-pushed
the
consistency-fixes
branch
from
July 31, 2026 19:37
7805ab5 to
58e6c00
Compare
| description: Shared MD5 password for BGP sessions. | ||
| type: string | ||
| required: | ||
| - ipv4Subnet |
Contributor
There was a problem hiding this comment.
Do we want to force v4 as required but not v6?
| type: string | ||
| required: | ||
| - asn | ||
| - hostIpv4 |
Contributor
There was a problem hiding this comment.
Same v4 vs v6 question here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.