feat(trace): first-class side_effect record and lane (#465 Phase A, 1/5) - #468
Open
AminChirazi wants to merge 1 commit into
Open
feat(trace): first-class side_effect record and lane (#465 Phase A, 1/5)#468AminChirazi wants to merge 1 commit into
AminChirazi wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
AminChirazi
added
the
needs-human
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 1/5 of #465 Phase A (side-effect capture). Human-authorized work on the rewritten issue body; trace-format change ⇒ needs-human review (CHARTER §8).
IMPORTANT — squash-merge this PR. Invariant 5 requires serde types +
crates/flowproof-trace/schema/side-effect-v1.schema.json+docs/trace-format.mdto land in ONE commit onmain; this PR's range bundles all three.What
The additive
side_effectslane on the agent-trace document: the sharedSideEffecttype inflowproof-trace(kind/target/target_note/op/flags/at_ms, withbefore/after/diffreserved and never emitted),SideEffectsTraceonAgentTrace(alwaysNonein this PR — capture arrives in 2/5 and 3/5), the lane's JSON Schema + conformance test, the committed falsifiability fixture it validates, and the trace-format docs including the sha256 confirmation-oracle residual. Old traces deserialize and re-serialize byte-identically (new sibling round-trip tests; existing tests untouched except compiler-forcedside_effects: Noneliteral additions).Evidence
cargo fmt --check0 ·clippy --workspace --all-targets -- -D warnings0 ·cargo test --workspace0 ·cargo check --workspace --all-targets --target x86_64-unknown-linux-gnu0 ·scripts/gate/ratchets.sh(BASE=main) exit 0, diff 400/400.Stack: this PR ← #2/5 (fs capture) ← #3/5 (http capture) ← #4/5 (assertion) ← #5/5 (falsifiability). Design was produced and adversarially reviewed against CHARTER §2 across three rounds before implementation.
🤖 Generated with Claude Code