feat(agent): record observed fs writes into the side-effect lane (#465 Phase A, 2/5) - #469
Open
AminChirazi wants to merge 1 commit into
Open
feat(agent): record observed fs writes into the side-effect lane (#465 Phase A, 2/5)#469AminChirazi wants to merge 1 commit into
AminChirazi wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 2/5 of #465 Phase A. Stacked on #468 — merge that first, then retarget/merge this.
What
Promotes the Linux seccomp filesystem observation from stderr-only report to a recorded
fs_writeside effect. The stderr report (report_fs, issue #302 behavior) is unchanged.FsEventgains a structuredpath2rename destination (retiring the ambiguous"src -> dst"join at capture),AgentRungainsobserved, and the lane builder routes every path through a total hygiene function: the only path-bearing output is a./-prefixed workspace-relative name (no component rewritten); traversal (..) forms, outside-workspace, and unanchored-relative paths all redact to asha256:12-hex note — never normalized-and-kept, so a symlinked..cannot misattribute an outside write as a workspace file. The lane joins theassert_no_secret_leakstore-guard corpus before the trace is minted (invariant 9).docs/agent-testing.mdowns the reversal of the previously-declined fs lane, naming #465 as the human act and keeping the original objection verbatim.Notes for review
path2: None,observed: false); no assertion changed. Hand-rolled deterministic property tests (4000 cases), no new dev-dependency.flowproof-clinow namessha2 0.10as a direct dependency (needed for the mandated redaction hashes; already in the build graph viapdf-extract -> lopdf, zero new lockfile packages, never in public API). If "no new public dependency" is read as "no new direct Cargo.toml entry at all", please say so and we substitute.Evidence
fmt 0 · clippy 0 ·
cargo test --workspace0 · Linux cross-check 0 · ratchets.sh exit 0, diff 400/400.🤖 Generated with Claude Code