Skip to content

fix: guard against undefined table in updateKeyName #3141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
okxint wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −1
Open

fix: guard against undefined table in updateKeyName #3141

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...region]-[project]/databases/database-[database]/table-[table]/columns/relationship.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,9 @@
function updateKeyName() {
if (!editing) {
const table = tableList.tables.find((n) => n.$id === data.relatedTable);
data.key = camelize(table.name);
if (table) {
Comment on lines 112 to +113

@greptile-apps greptile-apps Bot Jul 27, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Table list remains unguarded

When the related-table change event runs before the asynchronous table-list request completes, tableList.tables is dereferenced while tableList is undefined, causing a runtime error before the new missing-table guard is reached.

Prompt To Fix With AI 
This is a comment left during a code review.
Path: src/routes/(console)/project-[region]-[project]/databases/database-[database]/table-[table]/columns/relationship.svelte
Line: 112-113

Comment:
**Table list remains unguarded**

When the related-table change event runs before the asynchronous table-list request completes, `tableList.tables` is dereferenced while `tableList` is undefined, causing a runtime error before the new missing-table guard is reached.

How can I resolve this? If you propose a fix, please make it concise.

Fix in Claude Code Fix in Codex

data.key = camelize(table.name);
}
}
}

Expand Down