fix: guard against undefined table in updateKeyName - #3141
Conversation
tableList.tables.find() returns undefined when the selected table is not yet in the loaded page or the list hasn't finished loading. Dereferencing table.name without a null check caused a TypeError crash when creating a relationship attribute. Add an explicit guard so data.key is only updated when the table is found.
Greptile SummaryThis PR makes relationship-column key derivation skip missing table lookup results.
Confidence Score: 3/5This PR should not merge until The new result guard prevents reading Files Needing Attention: src/routes/(console)/project-[region]-[project]/databases/database-[database]/table-[table]/columns/relationship.svelte Important Files Changed
Prompt To Fix All With AIFix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
src/routes/(console)/project-[region]-[project]/databases/database-[database]/table-[table]/columns/relationship.svelte:112-113
**Table list remains unguarded**
When the related-table change event runs before the asynchronous table-list request completes, `tableList.tables` is dereferenced while `tableList` is undefined, causing a runtime error before the new missing-table guard is reached.
Reviews (1): Last reviewed commit: "fix: guard against undefined table in up..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| const table = tableList.tables.find((n) => n.$id === data.relatedTable); | ||
| data.key = camelize(table.name); | ||
| if (table) { |
There was a problem hiding this comment.
When the related-table change event runs before the asynchronous table-list request completes, tableList.tables is dereferenced while tableList is undefined, causing a runtime error before the new missing-table guard is reached.
Prompt To Fix With AI
This is a comment left during a code review.
Path: src/routes/(console)/project-[region]-[project]/databases/database-[database]/table-[table]/columns/relationship.svelte
Line: 112-113
Comment:
**Table list remains unguarded**
When the related-table change event runs before the asynchronous table-list request completes, `tableList.tables` is dereferenced while `tableList` is undefined, causing a runtime error before the new missing-table guard is reached.
How can I resolve this? If you propose a fix, please make it concise.
1 participant
Array.find()returnsundefinedwhen no table matches the selectedrelatedTableid (e.g. while the table list is still loading or the value was pre-populated from a saved state). Calling.nameonundefinedthrows a runtime error.Added an
if (table)guard before accessingtable.name.