Skip to content

RANGER-5754: Fix timezone-sensitive test failures in MiscUtilTest #1173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dhavalshah9131 merged 2 commits into from
Aug 24, 2026
+6 −4
Merged

RANGER-5754: Fix timezone-sensitive test failures in MiscUtilTest #1173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1dea20e
RANGER-5754: Fixed incorrect DST offset in MiscUtil.getUTCDateForLoca…
ChinmayHegde24 Aug 23, 2026
1d7d8e3
RANGER-5754: Fixed incorrect DST offset in StringUtil class of agents…
ChinmayHegde24 Aug 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion agents-audit/core/src/main/java/org/apache/ranger/audit/provider/MiscUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -843,7 +843,7 @@ public static UserGroupInformation getLoginUser() throws IOException {
public static Date getUTCDateForLocalDate(Date date) {
TimeZone gmtTimeZone = TimeZone.getTimeZone("GMT+0");
Calendar local = Calendar.getInstance();
int offset = local.getTimeZone().getOffset(local.getTimeInMillis());
int offset = local.getTimeZone().getOffset(date.getTime());
GregorianCalendar utc = new GregorianCalendar(gmtTimeZone);

utc.setTimeInMillis(date.getTime());
Expand Down
6 changes: 4 additions & 2 deletions agents-audit/core/src/test/java/org/apache/ranger/audit/provider/MiscUtilTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
import java.nio.file.Path;
import java.security.PrivilegedAction;
import java.security.PrivilegedExceptionAction;
import java.text.SimpleDateFormat;
import java.util.Calendar;
import java.util.Date;
import java.util.List;
Expand Down Expand Up @@ -125,8 +126,9 @@ void testGetEnv() {
void testGetFormattedTime() {
long timestamp = 1609459200000L; // 2021-01-01 00:00:00 UTC

// Test with valid format
assertEquals("2021-01-01", MiscUtil.getFormattedTime(timestamp, "yyyy-MM-dd"));
SimpleDateFormat sdf = new SimpleDateFormat("yyyy-MM-dd");
String expected = sdf.format(timestamp);
assertEquals(expected, MiscUtil.getFormattedTime(timestamp, "yyyy-MM-dd"));

// Test with invalid format
assertNull(MiscUtil.getFormattedTime(timestamp, "invalid"));
Expand Down
2 changes: 1 addition & 1 deletion agents-common/src/main/java/org/apache/ranger/authorization/utils/StringUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ public static Date getUTCDate() {

public static Date getUTCDateForLocalDate(Date date) {
Calendar local = Calendar.getInstance();
int offset = local.getTimeZone().getOffset(local.getTimeInMillis());
int offset = local.getTimeZone().getOffset(date.getTime());
GregorianCalendar utc = new GregorianCalendar(gmtTimeZone);

utc.setTimeInMillis(date.getTime());
Expand Down