RANGER-5754: Fix timezone-sensitive test failures in MiscUtilTest - #1173
Open
ChinmayHegde24 wants to merge 2 commits into
Open
RANGER-5754: Fix timezone-sensitive test failures in MiscUtilTest#1173ChinmayHegde24 wants to merge 2 commits into
ChinmayHegde24 wants to merge 2 commits into
Conversation
dhavalshah9131
self-requested a review
August 23, 2026 12:56
dhavalshah9131
approved these changes
Aug 23, 2026
ramackri
approved these changes
Aug 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Timezone-dependent unit test failures found in MiscUtilTest (failure outside UTC)
mainly in testGetFormattedTime and testGetUTCDateForLocalDate.
Fix
testGetFormattedTime: Replaced hardcoded "2021-01-01" with an expected value generated by the same SimpleDateFormat logic as production, so the test uses JVM local timezone and stays timezone-agnostic.testGetUTCDateForLocalDate: Fixed incorrect DST offset in MiscUtil.getUTCDateForLocalDate and StringUtil.getUTCDateForLocalDate causing test failure outside UTC timezonesTest:
Successful build
Successful run with both