Skip to content

FINERACT-2651: Refactor MixReportApiResource to return type-safe JAX-RS Response #6017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DhroovSankla wants to merge 1 commit into
base: develop
Choose a base branch
from
+5 −5
Open

FINERACT-2651: Refactor MixReportApiResource to return type-safe JAX-RS Response #6017

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions fineract-mix/src/main/java/org/apache/fineract/mix/api/MixReportApiResource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,12 +44,13 @@ public class MixReportApiResource {
@GET
@Produces({ MediaType.APPLICATION_XML })
@Operation(summary = "Retrieve Mix XBRL report", operationId = "retrieveMixReport")
public String retrieveXBRLReport(@QueryParam("startDate") final Date startDate, @QueryParam("endDate") final Date endDate,
@QueryParam("currency") final String currency) {
public jakarta.ws.rs.core.Response retrieveXBRLReport(@QueryParam("startDate") final Date startDate,

@oluexpert99 oluexpert99 Jun 24, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use imports

@QueryParam("endDate") final Date endDate, @QueryParam("currency") final String currency) {

final var data = xbrlResultService.getXBRLResult(startDate, endDate, currency);

// TODO: make this type safe?
return this.xbrlBuilder.build(data);
String xmlPayload = this.xbrlBuilder.build(data);

return jakarta.ws.rs.core.Response.ok().entity(xmlPayload).type(MediaType.APPLICATION_XML_TYPE).build();

@oluexpert99 oluexpert99 Jun 24, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use imports

@DhroovSankla DhroovSankla Jun 25, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oluexpert99 got it!

}
}
1 change: 0 additions & 1 deletion fineract-mix/src/main/java/org/apache/fineract/mix/service/MixReportXBRLBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ public class MixReportXBRLBuilder {

private final MixReportXBRLNamespaceReadService readNamespaceService;

// TODO: we should do this with JAXB
public String build(final MixReportXBRLData xbrlData) {
return this.build(xbrlData.getResultMap(), xbrlData.getStartDate(), xbrlData.getEndDate(), xbrlData.getCurrency());
}
Expand Down
Loading