FINERACT-2651: Refactor MixReportApiResource to return type-safe JAX-RS Response#6017
Open
DhroovSankla wants to merge 1 commit into
Open
FINERACT-2651: Refactor MixReportApiResource to return type-safe JAX-RS Response#6017DhroovSankla wants to merge 1 commit into
DhroovSankla wants to merge 1 commit into
Conversation
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
oluexpert99
reviewed
Jun 24, 2026
| @Operation(summary = "Retrieve Mix XBRL report", operationId = "retrieveMixReport") | ||
| public String retrieveXBRLReport(@QueryParam("startDate") final Date startDate, @QueryParam("endDate") final Date endDate, | ||
| @QueryParam("currency") final String currency) { | ||
| public jakarta.ws.rs.core.Response retrieveXBRLReport(@QueryParam("startDate") final Date startDate, |
oluexpert99
reviewed
Jun 24, 2026
| return this.xbrlBuilder.build(data); | ||
| String xmlPayload = this.xbrlBuilder.build(data); | ||
|
|
||
| return jakarta.ws.rs.core.Response.ok().entity(xmlPayload).type(MediaType.APPLICATION_XML_TYPE).build(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request addresses architectural refactoring for the Mix Report module by enforcing JAX-RS framework best practices and cleaning up obsolete placeholders.
Proposed Changes
retrieveXBRLReportinsideMixReportApiResource.javato return an explicitly typedjakarta.ws.rs.core.Responsewrapper entity instead of a rawString. This ensures proper JAX-RS native response handling and standard content negotiation.TODOcomments regarding marshalling engines and type safety fromMixReportApiResource.javaandMixReportXBRLBuilder.java.Related Issue
Fixes: FINERACT-2651
Checklist