Skip to content

Spell out the empty version suffix for the SVN provider build #71247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
potiuk wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −3
Open

Spell out the empty version suffix for the SVN provider build #71247

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions dev/README_RELEASE_PROVIDERS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -590,20 +590,29 @@ Set tags for the providers in the repo.
echo "Tagging with providers/${RELEASE_DATE}"
git tag -s providers/${RELEASE_DATE} -m "Tag providers for ${RELEASE_DATE}" --force
git push upstream providers/${RELEASE_DATE}
breeze release-management prepare-provider-distributions --include-removed-providers --distribution-format both
breeze release-management prepare-provider-distributions --include-removed-providers --distribution-format both --version-suffix ""
breeze release-management prepare-tarball --tarball-type apache_airflow_providers --version "${RELEASE_DATE}"
```

The `prepare-*-distributions` commands should produce the reproducible `.whl`, `.tar.gz` packages in the dist folder.
The `prepare-tarball` command should produce reproducible `-source.tar.gz` tarball of sources.

> [!IMPORTANT]
> `--version-suffix ""` is passed deliberately, and the empty value is the point: the packages
> committed to SVN carry the **final** version in their filename (`...-6.0.1-py3-none-any.whl`), with
> no `rcN`. That is what lets a passing vote promote them with a plain `svn mv` instead of a rebuild.
> The [PyPI upload below](#publish-the-regular-distributions-to-pypi-release-candidates) is the
> opposite case - it builds a *separate* set of packages from the same sources with
> `--version-suffix rcN`, so those filenames do carry the candidate number. Mixing the two up
> produces an SVN wave that cannot be promoted.

if you only build few packages, run:

```shell script
echo "Tagging with providers/${RELEASE_DATE}"
git tag -s providers/${RELEASE_DATE} -m "Tag providers for ${RELEASE_DATE}" --force
git push upstream providers/${RELEASE_DATE}
breeze release-management prepare-provider-distributions --include-removed-providers --distribution-format both PACKAGE PACKAGE ....
breeze release-management prepare-provider-distributions --include-removed-providers --distribution-format both --version-suffix "" PACKAGE PACKAGE ....
breeze release-management prepare-tarball --tarball-type apache_airflow_providers --version "${RELEASE_DATE}"

```
Expand Down Expand Up @@ -1138,7 +1147,7 @@ rm -rf dist/*
4) Build the packages using checked out sources

```shell
breeze release-management prepare-provider-distributions --include-removed-providers --distribution-format both
breeze release-management prepare-provider-distributions --include-removed-providers --distribution-format both --version-suffix ""
breeze release-management prepare-tarball --tarball-type apache_airflow_providers --version "${RELEASE_DATE}"
```

Expand Down
Loading