Spell out the empty version suffix for the SVN provider build - #71247
Open
potiuk wants to merge 1 commit into
Open
Spell out the empty version suffix for the SVN provider build#71247potiuk wants to merge 1 commit into
potiuk wants to merge 1 commit into
Conversation
The command omitted --version-suffix entirely, which reads as 'the flag does not matter here' rather than 'it must be empty'. Building the SVN wave with an rc suffix produces filenames that cannot be promoted by renaming, and the mistake only surfaces at the end of the release when the promotion is attempted.
potiuk
requested review from
bugraoz93,
jedcunningham,
jscheffl,
shahar1 and
vincbeck
as code owners
August 6, 2026 16:47
boring-cyborg
Bot
added
area:dev-tools
backport-to-v3-3-test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release doc builds the SVN wave with:
No
--version-suffix. The prose a few paragraphs earlier does say the packages "should keep the final version number without the rc suffix", but an omitted flag reads as this flag does not matter here rather than it must be empty — especially next to the PyPI section, which passes--version-suffix rcNfor what looks like the same command.Get it wrong and the SVN wave is built as
apache_airflow_providers_airbyte-6.0.1rc2-py3-none-any.whlinstead of...-6.0.1-.... Nothing complains at the time. It surfaces at the end of the release, when promoting the RC is supposed to be a plainsvn mvand instead needs a full rebuild, re-sign and re-commit of the whole wave. That happened during the 2026-08-06 wave.This passes
--version-suffix ""explicitly at all three build sites — the RC build, the few-packages variant, and the reproducible-build verification (which has to match how the artifacts were actually produced, or the check compares against differently-named files) — and adds a note stating why the empty value is the point, and how the SVN and PyPI builds differ.Docs only; no behaviour change.
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Opus 5 (1M context) following the guidelines