Update vulnerable npm dependencies - #38
Draft
ryanduguid wants to merge 2 commits into
Draft
Conversation
Moves the credential-store binding to the current release line and updates the lockfile to match.
Raises the vitest devDependency from ^2 to ^4.1.10 and regenerates package-lock.json against it. Only the vitest range changes, but the regeneration also advances locked in-range versions across the tree, including runtime dependencies (axios 1.13.6 -> 1.19.0, form-data 4.0.5 -> 4.0.6, follow-redirects 1.15.11 -> 1.16.0, brace-expansion 5.0.4 -> 5.0.9). That clears every advisory npm audit currently reports against the previous lockfile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@napi-rs/keyringto its patched 1.3 line;The refreshed lock resolves with zero npm audit findings under the existing Node >=18 contract.
Packaging relationship to #37
This dependency change does not alter lifecycle scripts. On exact head
8a1120a1787125afc3eb1cb80f063373cafe4baa,npm pack --dry-runsuccessfully builds and writes the oclif manifest, then reproduces the pre-existing Windows failure in the unchanged POSIX-onlyrm -fpostpack command. The generated manifest was removed and no tarball or untracked file remains.A detached composition of this exact head with #37 (
295d131e1805baab3d457ab5342b651a87dc11f4; composed commitc2ff3ba) completes the full lifecycle on Windows. No combined branch or PR was pushed. Maintainers can review the dependency and portability changes independently, but #37 is needed for Windows packaging.Verification
Exact #38 head:
npm ci— 309 packages audited, zero vulnerabilities;npm test -- --run— 130 passed;npm run buildpassed;npm pack --dry-run— prepack succeeded; unchanged Windowsrmpostpack failed as documented above;oclif.manifest.json,.tgzor untracked file remains.Temporary #38 + #37 composition:
npm ci— zero vulnerabilities;npm test -- --run— 130 passed;npm run buildpassed;npm pack --dry-runpassed: 179 files, 61.4 kB package / 463.3 kB unpacked;oclif.manifest.json; no tarball or untracked file remains.