Make postpack cleanup cross-platform - #37
Draft
ryanduguid wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the POSIX-only
rm -fpostpack command with Node's cross-platformfs.rmSync(..., {force: true}).The package already requires Node, so this adds no dependency and changes only lifecycle cleanup.
Verification at
295d131e1805baab3d457ab5342b651a87dc11f4npm ci;npm pack --dry-runpassed on Windows;oclif.manifest.jsonwas removed after packing.Compatibility with #38
A detached composition of #38 exact head
8a1120a1787125afc3eb1cb80f063373cafe4baaplus this commit producedc2ff3balocally; no combined branch was pushed.On that composition:
npm ciaudited 309 packages with zero vulnerabilities;npm pack --dry-runpassed with 179 files (61.4 kB packed / 463.3 kB unpacked);By contrast, #38 alone reaches postpack and reproduces the unchanged
rmfailure on Windows. This confirms this focused portability change supplies the missing lifecycle fix and composes cleanly with the dependency refresh.