feat(ui): selection card tells the truth about multi-selects (21.5, #88) - #114
Open
cubetribe wants to merge 1 commit into
Open
feat(ui): selection card tells the truth about multi-selects (21.5, #88)#114cubetribe wants to merge 1 commit into
cubetribe wants to merge 1 commit into
Conversation
The command card no longer takes the lead unit's word for a multi-selection:
buttons are the intersection over every MOBILE role (GetSharedUnitCommands —
building roles are skipped first, their None would wipe the AND), titled
"{lead type} — N Einheiten" with per-type breakdown rows "2× Lynx —
180/240 HP" in first-occurrence order. Mixed-in buildings ride along as
bystander rows without a command vote, mirroring the input discipline of
TryGetLeadProducer; only an all-building selection keeps the building card.
A single damaged unit carries its HP in the title, same convention as the
building card. EstimateHeight grows row-for-row with OnGUI.
Deliberate consequences (the sprint's reading: only commands that hold for
everyone): Harvest/ReturnCargo appear only on a pure Harvester selection —
which retires the dead Harvest button on mixed selections, the executor
rejects it for non-Harvesters anyway — and Repair only on a pure Builder
selection.
Verified: dotnet test 726/726; Unity EditMode 614/614 (9 new); PlayMode
12/13 (sole failure is the pre-existing NetworkPanel one, red on main too).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was
Paket 21.5 aus Sprint 21 (#88): die Befehlskarte sagt bei Mehrfachauswahl die Wahrheit.
GetSharedUnitCommands: Gebäude liefernNoneund werden vorher übersprungen, sonst löschen sie die Schnittmenge). Die angebotenen Befehle hängen nicht mehr von der Auswahl-Reihenfolge ab.TryGetLeadProducer).EstimateHeightist zeilengenau nachgetragen.Bewusste Konsequenzen (Sprint-Lesart „nur Befehle, die für alle gelten")
Nachweis
dotnet test tools/Nova.SimRunner.Tests -c Release: 726/726 grün (inkl.PresentationSourceBoundaryTests)NetworkPanel_ValidatesMasks...(PlayMode-Test NetworkPanel_ValidatesMasks… ist auf main rot — und niemand sieht es, weil die CI keine Unity-Tests fährt #110, auch auf main rot)Betroffene Bereiche
CommandCardPresenter(neue reine Funktionen),CommandCardHud(Modell/OnGUI/EstimateHeight),CommandCardPresenterTests,CHANGELOG.md(eine Zeile unter[Unreleased]→ Hinzugefügt). Kein Sim-Eingriff, keine Baseline-Bewegung.Merge-Hinweis: bei der CHANGELOG-Zeile kann es mit dem 21.3-PR eine triviale Überschneidung geben (beide oben im selben Abschnitt) — Auflösung: beide Zeilen behalten.