Group provider integrations in the grid#1336
Draft
RhysSullivan wants to merge 5 commits into
Draft
Conversation
This was referenced Jul 6, 2026
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | cb4c97a | Commit Preview URL Branch Preview URL |
Jul 07 2026, 12:21 AM |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-cloud | cb4c97a | Jul 07 2026, 12:23 AM |
Contributor
Cloudflare preview
Sign-in is Cloudflare Access (one-time PIN to an allowed email). The preview has its own database and encryption key; it is destroyed when this PR closes. |
@executor-js/cli
@executor-js/config
@executor-js/execution
@executor-js/sdk
@executor-js/codemode-core
@executor-js/runtime-quickjs
@executor-js/plugin-file-secrets
@executor-js/plugin-graphql
@executor-js/plugin-keychain
@executor-js/plugin-mcp
@executor-js/plugin-onepassword
@executor-js/plugin-openapi
executor
commit: |
40a4b18 to
609d07e
Compare
73b73fa to
20b145b
Compare
Provider plugins that fan out into per-service integrations (Google -> Calendar, Gmail, Drive; Microsoft -> Mail, Calendar, Teams) now declare a per-service slug->icon map. The catalog favicon resolver consults it by the integration slug before the URL/token preset cascade, so a Gmail source shows the Gmail glyph rather than a generic Google logo. Kept separate from presets so the connect picker's popular list is untouched.
Integrations whose kind is in the multi-service family allowlist (google, microsoft) now collapse under one collapsible provider card on the integrations list: a Google umbrella carrying the Calendar, Gmail, Drive, and custom rows, keyed by kind. A family with a single member and every non-family integration render flat as before, and groups appear where their first member would have. Adds an e2e spec asserting the grouping, that a non-family integration stays ungrouped, and that the per-service icons are distinct.
On selfhost every scenario shares the bootstrap admin, so the per-service add specs that run earlier in the job leave google_custom (and the preset integrations) behind. The Google add flow disables its submit button when the custom slug already exists, so the grid spec timed out clicking it. Check the grid first and only run the add flow for integrations that are actually missing, tolerating skipped rows, and remove what the spec created in a finalizer so no state leaks into later scenarios.
20b145b to
0e7169f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Groups per-service Google and Microsoft integrations under a collapsible provider card in the integrations list, and gives each service its own icon. Non-provider integrations render as before.
Stack