Fix a CompiledSimulation concat bug#498
Merged
Merged
Conversation
The bug occurs when the first arg to `concat` crosses a 64-bit limb boundary. The checks in `_build_concat` were reversed: We must check if the current arg has more bits before checking if we're done with the `concat`. Add a new `test_concat_split_offset_start` test that fails without this fix.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## development #498 +/- ##
=============================================
+ Coverage 92.2% 92.3% +0.1%
=============================================
Files 30 30
Lines 7488 7488
=============================================
+ Hits 6902 6905 +3
+ Misses 586 583 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug occurs when the first arg to
concatcrosses a 64-bit limb boundary. The checks in_build_concatwere reversed: We must check if the current arg has more bits before checking if we're done with theconcat.Add a new
test_concat_split_offset_starttest that fails without this fix.