Miscellaneous CompiledSimulation and Simulation cleanup, for 8% speedup (pyrtlnet CompiledSimulation startup)#497
Open
fdxmw wants to merge 3 commits into
Open
Miscellaneous CompiledSimulation and Simulation cleanup, for 8% speedup (pyrtlnet CompiledSimulation startup)#497fdxmw wants to merge 3 commits into
CompiledSimulation and Simulation cleanup, for 8% speedup (pyrtlnet CompiledSimulation startup)#497fdxmw wants to merge 3 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## development #497 +/- ##
=============================================
+ Coverage 92.3% 93.9% +1.6%
=============================================
Files 30 30
Lines 7488 7138 -350
=============================================
- Hits 6905 6696 -209
+ Misses 583 442 -141 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
The coverage report shows that some pretty important lines of |
CompiledSimulation and Simulation cleanup, for 5% speedup (pyrtlnet CompiledSimulation startup)CompiledSimulation and Simulation cleanup, for 8% speedup (pyrtlnet CompiledSimulation startup)
…peedup (pyrtlnet CompiledSimulation startup): * Refactor to remove redundant code. * Use f-strings instead of `.format`. * Use `_limb_name` (formerly `_getarglimb`) consistently. * Define a `dataclass` for `_build_concat`'s `pieces`. * Define `dataclass`es for `Input` and `Output` metadata. * Rename a lot of variables to improve readability. * Add comments, type annotations, and assertions. * Add tests.
* Remove legacy `omit` filename patterns. * Ignore `PyrtlInternalError` and exception error messages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.format._limb_name(formerly_getarglimb) consistently.dataclassfor_build_concat'spiecesso the pieces have names.