Skip to content

ci: Configure SDK compliance capture suite #711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
marandaneto wants to merge 1 commit into from
Closed

ci: Configure SDK compliance capture suite #711

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/sdk-compliance.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,11 @@ on:
jobs:
compliance:
name: PostHog SDK compliance tests
uses: PostHog/posthog-sdk-test-harness/.github/workflows/test-sdk-action.yml@be8b8d5a3f94a249659844e94832e874f049c1e4
uses: PostHog/posthog-sdk-test-harness/.github/workflows/test-sdk-action.yml@fix/sdk-harness-options-20260630

@greptile-apps greptile-apps Bot Jun 30, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Mutable branch reference in reusable workflow call

The workflow now references fix/sdk-harness-options-20260630 (a branch) instead of the previously pinned SHA. Branch refs are mutable — any commit pushed to that branch will be picked up on the next run without any code review on this side. The previous SHA pin (be8b8d5a3f94a249659844e94832e874f049c1e4) gave a guaranteed-immutable reference. Once the harness branch is merged and a stable commit is available, this should be pinned back to a SHA to avoid unexpected behavior or supply-chain risk.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

with:
adapter-dockerfile: "sdk_compliance_adapter/Dockerfile"
adapter-context: "."
test-harness-version: "0.8.0"
suite: "capture"
sdk-type: "server"

@greptile-apps greptile-apps Bot Jun 30, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 continue-on-error as a with input may not make failures non-blocking

continue-on-error: true passed via with: is just a named input to the reusable workflow — it only suppresses failures if the callee explicitly declares it as an input and sets it on its own jobs. It does not automatically affect the calling job. To guarantee that a compliance failure doesn't block the PR regardless of how the harness workflow is implemented, add continue-on-error: true as a top-level job property here as well. If the harness branch does handle this input internally, the two settings are complementary and the job-level property is still the safe approach given that it's a temporary non-blocking window.

continue-on-error: true
2 changes: 1 addition & 1 deletion sdk_compliance_adapter/docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ services:
# Test harness
test-harness:
image: ghcr.io/posthog/sdk-test-harness:0.8.0
command: ["run", "--adapter-url", "http://sdk-adapter:8080", "--mock-url", "http://test-harness:8081"]
command: ["run", "--adapter-url", "http://sdk-adapter:8080", "--mock-url", "http://test-harness:8081", "--sdk-type", "server", "--suite", "capture"]
networks:
- test-network
depends_on:
Expand Down
Loading