ci: Configure SDK compliance capture suite#711
Conversation
|
Reviews (1): Last reviewed commit: "ci: Configure SDK compliance capture sui..." | Re-trigger Greptile |
| compliance: | ||
| name: PostHog SDK compliance tests | ||
| uses: PostHog/posthog-sdk-test-harness/.github/workflows/test-sdk-action.yml@be8b8d5a3f94a249659844e94832e874f049c1e4 | ||
| uses: PostHog/posthog-sdk-test-harness/.github/workflows/test-sdk-action.yml@fix/sdk-harness-options-20260630 |
There was a problem hiding this comment.
Mutable branch reference in reusable workflow call
The workflow now references fix/sdk-harness-options-20260630 (a branch) instead of the previously pinned SHA. Branch refs are mutable — any commit pushed to that branch will be picked up on the next run without any code review on this side. The previous SHA pin (be8b8d5a3f94a249659844e94832e874f049c1e4) gave a guaranteed-immutable reference. Once the harness branch is merged and a stable commit is available, this should be pinned back to a SHA to avoid unexpected behavior or supply-chain risk.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
| adapter-context: "." | ||
| test-harness-version: "0.8.0" | ||
| suite: "capture" | ||
| sdk-type: "server" |
There was a problem hiding this comment.
continue-on-error as a with input may not make failures non-blocking
continue-on-error: true passed via with: is just a named input to the reusable workflow — it only suppresses failures if the callee explicitly declares it as an input and sets it on its own jobs. It does not automatically affect the calling job. To guarantee that a compliance failure doesn't block the PR regardless of how the harness workflow is implemented, add continue-on-error: true as a top-level job property here as well. If the harness branch does handle this input internally, the two settings are complementary and the job-level property is still the safe approach given that it's a temporary non-blocking window.
posthog-python Compliance ReportDate: 2026-06-30 10:02:24 UTC ✅ All Tests Passed!29/29 tests passed Capture Tests✅ 29/29 tests passed View Details
|
Problem
SDK compliance workflows need explicit harness suite/sdk-type selection and configurable blocking behavior so CI only runs the intended contract checks.
Changes
Testing
docker compose configfor the adapter compose file.git diff --check.Release / changeset
No SDK package changeset: CI/local compliance configuration only.
🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Implemented with Pi using dedicated git worktrees. The change was requested to align SDK compliance harness setup across SDK repositories while keeping non-ready SDKs non-blocking.