Jaden taking over for Carlos/Shravan fix conflicts 4351 (DONE Jaden) - #4954
Jaden taking over for Carlos/Shravan fix conflicts 4351 (DONE Jaden)#4954Shravan-neelamsetty wants to merge 0 commit into
Conversation
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
901060b to
6fa3e3b
Compare
|
one-community
added
the
High Priority - Please Review First
HemanthNidamanuru
left a comment
HemanthNidamanuru
left a comment
There was a problem hiding this comment.
Hi Shravan,
I tested this PR locally and everything looks good! One small thing to fix: the selected projects field background does not adapt properly in dark mode.
Anusha-Gali
left a comment
Anusha-Gali
left a comment
There was a problem hiding this comment.
Hi Shravan,
I have reviewed your PR locally and in "Total Construction Summary" i found the below issues:
- In Longest Open issues, the chart background when compare to the other charts on the page
- The Supplier Performance dropdown's in Tools and Equipment tracking are not adapted to the same color as other dropdown's.
- The options in the Injury Severity chart in Lessons Learned are not clearly visible when selected
- The options in the Planned vs Actual Cost in Financials are not clearly visible when selected
- The hover text in Global Distribution map is not visible, and a lot of dropdown's and other features are missing when compared to Dev
- The calendar in the Planned vs Actual Cost in Financials is in light mode
The rest of the charts are well adapted to dark mode. The Leaderboard page is also as per requirement.
Issues
No issues
2a4489a to
9b15db0
Compare
Mahitha-pasupuleti
left a comment
Mahitha-pasupuleti
left a comment
There was a problem hiding this comment.
Tested this PR locally and thoroughly reviewed the implemented changes. While the overall dark mode implementation and merge conflict resolution are heading in the right direction, I identified several issues that should be addressed before this PR can be approved:
- Dropdown Readability: The readability of the values within the dropdown menu is poor in dark mode due to low contrast, making it difficult for users to clearly distinguish the available options.
- Map Visibility in Dark Mode: The content displayed within the map component is not clearly visible in dark mode. The current styling significantly impacts readability and usability.
- Non-Functional Dropdowns: In both light and dark modes, the "Select Tools" and "Select a Project" dropdowns are not clickable, preventing users from interacting with these fields.
-
Paid Labor Cost Section: The Start Date and End Date fields are not visible in dark mode. Additionally, these fields overlap with nearby content, causing layout and usability issues.
-
Distribution of Labor Hours Form: The Submit button in the Distribution of Labor Hours section is not functioning, preventing form submission and breaking the workflow.
- Dark Mode State Inconsistency: Upon reloading the page and toggling between light and dark modes multiple times, several internal components do not consistently adopt dark mode styling. While the light mode sections render correctly, some nested elements remain in their default theme, resulting in an inconsistent UI experience.
Please review the issues above and the attached screenshots. Due to the functional and visual regressions identified during testing, I am requesting changes before approval.
|
There was a problem hiding this comment.
- Risk Profile for projects:
The rows of Trend Summary Table is not visible in dark mode. - Tools and Equipment tracking:
The Tools and Availability filters are not working and Supplier Performance by On-Time -- Delivery % filters shows No Data on filtering but shows chart for ALL value. The Project id is displayed instead of project name. - Labor and Time Tracking:
The calendar pop is not visible needs contrast improvement. - Loss Tracking Line Chart
Start Date and End date filter is not clickable. - Financials:
The filter values show are not visible. - Leaderboard on hovering makes the text invisible in dark mode.
- Failed to generate Pdf pop and clicking on generate pdf
There was a problem hiding this comment.
Hi Shravan, I tested this PR locally by checking out shravan-fix-conflicts-4351, running yarn install and yarn start:local, logging in as admin, and navigating to bmdashboard/totalconstructionsummary. I tested both light and dark mode across all sections. Here is my finding:
What's Working Well
- Risk Profile chart renders correctly in dark mode with good contrast
- Risk Movement Tracking cards are fully readable in dark mode
- The Trend Summary Table rows are now visible in dark mode - this addresses the previous concerns
- Project Status, Issues Breakdown, Loss Tracking, and Lessons Learned sections all
look good in dark mode - The Global Distribution map renders with visible country labels and project status dots
- The Leaderboard two-row layout and trophy icons look correct
Issues That Need To Be Addressed
1. Issue Tracking - Chart Background Not Adapting to Dark Mode
The "Longest Open Issues" chart container remains white when dark mode is active. The chart title, axis labels, and filter text are barely readable against the white background. This is inconsistent with every other chart section on the page which correctly adapts to dark mode.
2. Issue Tracking - Projects Dropdown Not Dark Mode Adapted
When the Projects dropdown is opened, the option list has a white/light background that does not adapt to dark mode.
3. Financials - Project and Category Dropdowns Not Dark Mode Adapted
Both the Project and Category dropdown input fields in the "Planned vs Actual Cost" section remain white in dark mode. When opened, the dropdown lists also have a white background with no dark mode styling applied.
4. Financials Tracking - Empty Cards and Unhandled Error
Two "Card" placeholder panels render empty with no content or loading state. A third panel displays a raw error message:
Error: Failed to load project cost data
This error is surfaced directly to the user without any friendly fallback UI or retry option.
5. PDF Generation - Functional Failure
Clicking "Share PDF" triggers a "Generating PDF..." notification followed immediately by a browser-level alert:
Failed to generate PDF. Please try again.
The feature does not work. This was also flagged by @DeepighaJ and does not appear to be fixed in this branch.
6. Leaderboard - Notification Banner Contrast in Dark Mode
The "Note: You are currently invisible to the team(s) you are on" banner has very poor contrast in dark mode - the text is difficult to read against the banner background.
7. Lessons Learned - Data Source and Date Inputs Not Dark Mode Adapted
The Data Source input box and the From/To date fields in the Most Frequent Keywords section remain white/light colored in dark mode, inconsistent with the surrounding dark UI.
8. Tools and Equipment - Input Fields Not Dark Mode Adapted
The "Tool(s)" and "Select a project" input fields in the Tools by Availability section remain white/light in dark mode.
UI Improvements Suggested
9. Inconsistent Section Widths
The "Financials", "Loss Tracking", and "Labor and Time Tracking" sections are noticeably narrower than all other sections on the page. This is visible in both light and dark mode and appears to be a layout bug. All sections should have consistent full-width containers.
10. Raw Error Messages Surfaced to Users
In Financials Tracking, errors are displayed as raw technical strings directly in the UI. A user-friendly error state with a clear message and a retry option would improve the experience significantly.
Dnagabahiru
left a comment
Dnagabahiru
left a comment
There was a problem hiding this comment.
Review Summary
Environment Setup:
- Checked out branch shravan-fix-conflicts-4351 locally.
- Ran npm install successfully.
- Ran the full test suite successfully.
- 312 test files passed
- 2094 tests passed
- 9 tests skipped
- Application started successfully using Vite on localhost.
Code Review:
- Reviewed the PR description and confirmed this is a merge-conflict resolution PR for #4351.
- Reviewed changed files related to CSS modules, dark mode styling, and conflict resolution.
- Did not find obvious unresolved merge conflict markers in the reviewed files.
Testing Performed:
- Verified the application builds and runs locally.
- Verified the automated test suite passes successfully.
- Reviewed the conflict-resolution changes in the modified files.
Testing Blocker:
- Unable to complete the required UI testing steps because login is blocked in my local environment.
- Login returns: "Invalid Credentials - User Not Found."
- Therefore I could not access:
- /bmdashboard/totalconstructionsummary
- Leaderboard page
- Unable to verify dark mode behavior, dropdowns, calendars, tooltips, and related UI functionality specified in the PR testing instructions.
Request:
Please provide the required admin/test credentials or access instructions so the functional testing steps can be completed before approval.
handikaharianto
left a comment
handikaharianto
left a comment
There was a problem hiding this comment.
Hi @Shravan-neelamsetty , the following are what you need to update.
Dark Mode
Trend Summary Table
Update the highlighting style when hovering the row.
Project Status
In mobile view, centering these cards or make it full width would look better.
Issue Tracking
Disable the dates before the start date when choosing end date & disable the dates after the end date when choosing start date to improve UX.
Tools and Equipment Tracking
Date pickers in both start and end date do not have dark mode.
Financials
- Update the dark mode styling for the dropdowns (project, category) and date pickers (start date, end date).
- The labels on X-axis and Y-axis are not visible, including the small numbers above the bar chart.
For the Cost Breakdown by Category section, update the dark mode styling for from and to.
Labor and Time Tracking
- The start and end date overlapped with the chart
- The opacity on these tasks, project, and date range lead to bad contrasts.
Financials Tracking
The Actual vs Planned Costs has bad contrast when hovering around the chart.
Light Mode
Material Consumption
Update the light mode styles for these dropdowns and multi-select.
Issue Tracking
This section does not have light mode styling.
Tools and Equipment Tracking
- The middle section (Tools by Availability) has bad contrast on the labels
- The dropdown and date picker triggers have no light mode styles.
Lessons Learned
The Most Frequent Keywords section has no light mode styles.
Leaderboard
Update styles when highlighting rows on dark mode.
|
Hi @Shravan-neelamsetty, I reviewed the pr and following are the things i found need to be fixed: 1. Layout ConsistencyThe spacing between collapsed dropdown sections is not consistent across the page. Some sections leave noticeably larger gaps than others, resulting in an uneven layout in both light and dark modes. Expected behavior: 
2. Risk Profile
3. Project StatusSome cards have insufficient color contrast in dark mode, affecting readability. 
4. Material ConsumptionInput fields do not consistently apply dark/light mode styling. 
5. Issue BreakdownLong X-axis labels overlap adjacent labels and reduce readability. 
6. Issue TrackingDark mode styling is not properly applied when toggling themes. It only renders correctly after refreshing the page while already in dark mode. 
7. Tools and Equipment Tracking
8. Lessons Learned
9. FinancialsInput fields do not properly follow dark mode styling. 
10. Loss TrackingClicking directly on the calendar icon does not open the date picker. The date picker only opens when clicking slightly to the left of the icon. 
11. Labor and Time Tracking
12. Financial TrackingThe Actual vs Planned Costs chart tooltip/hover state has poor contrast in dark mode. 
13. PDF GenerationPDF generation failed during testing. 
14. General Review
SummaryTested locally on branch |
There was a problem hiding this comment.
Tested PR #4954 locally on the shravan-fix-conflicts-4351 branch.
-
Weekly Project Summary:
Tested PR #4954 locally on the shravan-fix-conflicts-4351 branch.
Verified light mode and dark mode functionality.
Dark mode toggle worked correctly. -
Material Consumption:
First card appeared blank during testing.
Did not appear related to the dark mode changes in this PR. -
Financials Tracking:
Observed "Failed to load project cost data".
Browser console showed /api/project/1/predictions returning 404.
Issue does not appear to be introduced by this PR. -
Code Review:
Reviewed representative CSS module and dark mode changes.
No issues identified.
Screenshots attached.
Dnagabahiru
left a comment
Dnagabahiru
left a comment
There was a problem hiding this comment.
Verified Total Construction Summary in both Light and Dark modes.
Risk Profile, Tools & Equipment, Financials, filters, date pickers, tooltips, and calendar popups are functioning as expected.
Issue Found:
In Dark Mode, the Issue Tracking → Longest Open Issues chart has poor contrast and reduced visibility. Chart labels, legends, and tooltip content appear faded, impacting readability.
pixelpix13
left a comment
pixelpix13
left a comment
There was a problem hiding this comment.
Hi @Shravan-neelamsetty, I reviewed the pr and following are the things i found need to be fixed:
1. Layout Consistency
The spacing between collapsed dropdown sections is not consistent across the page. Some sections leave noticeably larger gaps than others, resulting in an uneven layout in both light and dark modes.
Expected behavior:
All collapsed dropdown rows should maintain consistent height, margin, and spacing to provide a uniform and visually balanced user experience.
2. Risk Profile
- Row hover background color in the Trend Summary table does not match dark mode styling.
- Tooltip for the Comparison + Indicators column displays a "?" and needs verification.
3. Project Status
Some cards have insufficient color contrast in dark mode, affecting readability.
4. Material Consumption
Input fields do not consistently apply dark/light mode styling.
5. Issue Breakdown
Long X-axis labels overlap adjacent labels and reduce readability.
6. Issue Tracking
Dark mode styling is not properly applied when toggling themes. It only renders correctly after refreshing the page while already in dark mode.
7. Tools and Equipment Tracking
- Tools by Availability section does not properly support dark mode.
- Dropdown/input fields do not function correctly.
- Theme toggle behavior is inconsistent.
8. Lessons Learned
- Dark/light mode styling is inconsistent after toggling.
- Calendar popup opens offset from the associated input field instead of directly underneath it.
9. Financials
Input fields do not properly follow dark mode styling.
10. Loss Tracking
Clicking directly on the calendar icon does not open the date picker. The date picker only opens when clicking slightly to the left of the icon.
11. Labor and Time Tracking
- Paid Labor Cost dropdowns appear transparent in dark mode.
- Adding multiple task values breaks alignment.
- Date range layout/alignment issues observed.
12. Financial Tracking
The Actual vs Planned Costs chart tooltip/hover state has poor contrast in dark mode.
13. PDF Generation
PDF generation failed during testing.
14. General Review
- Dashboard responsiveness is poor on smaller screens/mobile layouts.
- Date range UX could be improved by disabling invalid dates before the selected start date and after the selected end date.
- Dashboard interactions feel slow and unresponsive.
- Some table row hover states do not properly support dark mode styling.
Summary
Tested locally on branch shravan-fix-conflicts-4351 in both light and dark modes.
mahathiganimi
left a comment
mahathiganimi
left a comment
There was a problem hiding this comment.
Hi Shravan,
when I tested this page in my local - I found the following issues
Project Risk Profile Overview - Start date can be set as later than the end date. When 0 projects selected, I am still able to view all 5 projects charted, Is this the intended behaviour? Trend summary contents are difficult to read if they are highlighted using cursor.
Project Status - The numbers in the bubbles are hard to read with some colour backgrounds.
Material Consumption - Chart is not rendered. And the contents from select dropdown are totally difficult in terms of readability.
Issue Tracking - ToolTip hover does not give any details. Projects select dropdown is unreadable
Tools and equipment tracking - Tools by availability - No event triggers when I select dropdown.
Lessons Learned - Could improvise the colour palette for dropdown for most frequent keywords display
Financials - One chart is not rendered, Dropdown is difficult to read
Loss Tracking Line Chart - Not able to select dates
Labour and Time Tracking - Start date can be set as later than the end date.
Financials Tracking - Three charts are not rendered.
shree-vaths
left a comment
shree-vaths
left a comment
There was a problem hiding this comment.
Hi, I was able to test #4954 on my local.
Passing test cases
-The graphs of risk profiles, material consumption, tools & equipment, issues breakdown, financials, global distribution, labour & time tracking and financial tracking have adapted to dark mode.
-Forms on issues tracking, lessons learned are working in dark mode.
-Legend and tooltip information are adapted for dark mode.
-Date picker,project filters and category filters looks good in dark mode.
UI seems to be distorted but i believe its out of scope for this ticket.
akv-iu
left a comment
akv-iu
left a comment
There was a problem hiding this comment.
Hey @Shravan-neelamsetty, Tested PR locally. These are some things I found that needs to be fixed.
1. Layout Consistency
Spacing inconsistencies: The vertical spacing between collapsed dropdown sections is uneven. Margins and heights needs to be standardized, so the UI looks uniform across both light and dark themes.
Heading logic: Headings inside the dropdowns are inconsistent, some have, others don't.
2. Risk Profile
Hover states: In the Trend Summary table, the background color when hovering over a row, doesn't match the rest of the dark mode theme.
3. Project Status
Few cards are difficult to read in dark mode due to poor color contrast.
4. Material Consumption
Input fields do not consistently apply dark/light mode styling. Dark theme doesn’t work on drop down in 2 sections
5. Issue Tracking
Toggling dark mode doesn't apply the styles immediately; it requires a full page reload. Chart hover states are also failing to inherit the dark theme.
6. Tools and Equipment, Tracking
- This section do not properly support dark mode.
- Dropdown/input fields do not function correctly.
7. Lessons Learned
- Dark/light mode styling is inconsistent after toggling.
- Calendar Allows to select future date, first section doesn’t have dark theme in drop down
8. Loss Tracking
Clicking directly on the calendar icon does not open the date picker. The date picker only opens when clicking slightly to the left of the icon. No multi select option present for the graph (Year and Material)
Data inside the map is not visible, date can select future date
9. Labor and Time Tracking
- From date > to date accepted
HemanthNidamanuru
left a comment
HemanthNidamanuru
left a comment
There was a problem hiding this comment.
Hi Shravan,
I tested this PR locally on the shravan-fix-conflicts-4351 branch.
Most sections are working fine in both light and dark mode, and the Leaderboard page also looks good.
A few dark mode UI areas still need improvement:
The row hover effect in the Trend Summary table is not clearly visible.
The calendar in Tools by Availability needs better dark mode styling/alignment.
The Financials section also needs dark mode styling improvements.
BosuBose132
left a comment
BosuBose132
left a comment
There was a problem hiding this comment.
Tested PR #4954 locally on the pr-4954 branch.
What I verified:
- The app started locally with the backend running on development.
- The Total Construction Summary page loaded at /bmdashboard/totalconstructionsummary.
- I tested the page in dark mode and light mode.
- I checked multiple sections, including Material Consumption, Issue Tracking, Tools and Equipment Tracking, Financials, and Labor and Time Tracking.
- Several charts and dashboard sections are rendering, and the page is generally accessible for testing.
Issues found:
-
Dark mode styling is still inconsistent in several dropdowns and input fields. In sections such as Material Consumption, Tools and Equipment Tracking, Financials, and Labor and Time Tracking, the dropdowns/placeholders appear too light or have low contrast against the dark background. Some placeholder text is difficult to read.
-
Some dropdowns and input fields overlap the chart area. In the Labor and Time Tracking section, the Date Range fields overlap the Paid Labor Cost chart. In the Financials section, the Category dropdown overlaps the Planned vs Actual Cost chart. This makes the chart harder to read and affects the layout.
-
In the Issue Tracking section, the chart/card area does not fully match dark mode styling. The chart container appears too light, and some labels/text are hard to read in dark mode. It's happening the same in every section.
-
I also noticed a “Failed to load project cost data” message in the Financials Tracking section while testing. If this is expected due to backend/data availability, please confirm; otherwise, this may need to be checked.
Expected behavior:
The Total Construction Summary page should render consistently in both dark mode and light mode. Dropdowns, placeholders, date fields, chart labels, tooltips, and chart containers should have readable contrast, and input/dropdown elements should not overlap the charts.
Actual behavior:
Several dropdowns and placeholders have low contrast in dark mode, some chart areas are inconsistent with dark mode styling, and some fields overlap chart content.
Note: GitHub currently shows merge conflicts for this PR, so the branch will also need to be updated with development before final merge.
Screenshots attached for reference.
CarolineYXW
left a comment
CarolineYXW
left a comment
There was a problem hiding this comment.
Hi! I tested this PR in both Dark Mode and Light Mode and found several issues that should be addressed before merging.
Please see the comments below for details. Screenshots are attached for each issue.
1. Page becomes unresponsive
The page becomes unresponsive whenever I select the "Custom" time range and manually enter the year in the date input.
This issue occurs in both Dark Mode and Light Mode.
2. Chart labels
Suggestion:
The values displayed on the charts are difficult to read. Consider rounding the numbers and/or increasing the font size to improve readability.
This applies to both Dark Mode and Light Mode.
- Dropdown and date input visibility
The text inside the dropdowns and date input fields is not visible, making it difficult to read the selected values.
- Date picker not working
The date picker cannot be interacted with in this section. Clicking the date field does not allow selecting a date.
- Labor and Time Tracking issues
In the Labor and Time Tracking section:
- Clicking "Submit" after changing the filters does not update the chart.
- The date range input overlaps with the chart, causing a layout issue.
Both issues occur in Dark Mode and Light Mode.
Overall, I found several functional issues that should be resolved before this PR is merged. I also included one UI improvement suggestion (P2). Thank you for your work!
AnshShah-18
left a comment
AnshShah-18
left a comment
There was a problem hiding this comment.
I tested PR #4954 locally in both light and dark modes and found the following issues:
Issues in Dark mode:
- The Trend Summary Table row text becomes unreadable when hovering in dark mode.
- The first Material Consumption card is blank and only displays the title “Card.”
- In Financials, dropdown options become are unreadable and have poor contrast in dark mode
- In tools and Equipment tracking, the “Select tools” and “Select a project” dropdowns are not functional.
- The Loss Tracking Start Date and End Date fields cannot be selected.
- The Paid Labor Cost date fields overlap the chart.
- Two Financials Tracking charts are missing and Financials Tracking displays the raw error “Failed to load project cost data.”
- The Leaderboard table and hover states have poor contrast in dark mode.
Issues in Light mode:
- The first panel is blank and only displays the generic title “Card.” There is no chart, loading indicator, empty-state explanation, or error message.
- When hovering over a dropdown option, the background becomes very light while the text also remains light, making the selected option difficult to read.
- The entire Longest Open Issues chart remains dark blue while the rest of the page is in light mode. This creates inconsistent theme styling, and some chart labels also have weak contrast.
12.The middle card uses dark-colored dropdowns in light mode. The Select tools and Select a project dropdowns do not open or allow any selection, so the chart cannot be filtered and remains on “No tools data available.”
- The Most Frequent Keywords card retains a dark background even though light mode is active, resulting in inconsistent page styling.
- The first Financials panel displays only “Card” with no chart or meaningful empty/error state.
- The Start Date and End Date controls cannot be opened or selected, including when clicking the calendar icons.
- The Date Range fields are positioned directly over the Paid Labor Cost chart, hiding the legend and part of the chart. The section also leaves a very large unused area on the right.
17. Two cards are blank, another displays the technical message “Error: Failed to load project cost data,” and only one chart renders. The page should provide charts or clear, user-friendly empty/error states.
DeepighaJ
left a comment
DeepighaJ
left a comment
There was a problem hiding this comment.
The issues previously reported are not yet fixed here.
Risk profile for Project issue still not fixed.
Tools and Equipment Tracking: Tools by availablility filters are not clickable.
Financials: The filters need dark mode improvement and the Planned vs Actual chart can be improved as they appear big and have no x-axis and y-axis labels.
I'm still getting the issue "Failed to generate PDF" on clicking on the Share PDF button.
Labor and time Tracking: The filters are overlapped on the chart and need improvement on the contrast.
iAbhi001
left a comment
iAbhi001
left a comment
There was a problem hiding this comment.
Thanks! A few blocking items remain before we can merge:
Merge Conflicts: Needs resolution to enable deployment.
Unresolved Bugs: Risk Profile, non-clickable Tools filters, and the "Failed to generate PDF" error on Financials.
UI Issues: Dark mode contrast, missing chart axes, and overlapping filters on Labor & Time Tracking.
There was a problem hiding this comment.
Hi Shravan,
I ran and tested the PR locally
Issues
-
Risk Profile: Trend Summary Table has contrast issues when hovering
-
Issue Tracking: Light Mode isn't really light mode
-
Material Consumption section Light Mode has issues
-
Lessons Learned section has some components in Dark Mode while in Light Mode
-
Financials section has contrast issues for the filters and drop down menus in Dark Mode
-
Labor and Time Tracking section - In the Paid Labor Cost component, the filters are transparent in Dark Mode
-
Leaderboard Component has contrast issues when hovering in Dark Mode
one-community
changed the title
Jaden300
changed the title
Jaden300
changed the title
2910480
9e38dd0 to
2910480
Compare
Jaden300
changed the title
abf908c to
03f2563
Compare
|
|
New PR is here: #5437 |
20 participants
Jaden taking over for Carlos/Shravan fix conflicts 4351 (DONE Jaden)
This PR has been superseded. All changes have been moved to PR #5437 due to merge conflicts that could not be resolved here. Please review and track progress there instead.
PR #5437 (shravan-fix-conflicts-4351) picks up this work - it resets to a clean base off development, cherry-picks only the 22 files from Carlos's original dark mode work, and resolves all blocking issues including a broken API endpoint, field name mismatches, dead imports, stylelint and WCAG contrast violations, and SonarCloud code quality issues. All 29 tests pass.
Description
Took over from Carlos/Shravan to bring PR #4351 (dark mode implementation for the Total Construction Summary page) to a mergeable state.
The previous branch had accumulated ~212 files due to repeated
git merge developmentcalls pulling in unrelated work from other PRs. This PR resets to a clean base offdevelopmentand cherry-picks only the 22 files belonging to Carlos's original dark mode work, then resolves all blocking issues.Related PRs
Changes made
Branch cleanup
development- removed ~190 passenger files from other PRs that had accumulated via merge commitsBug fixes
ENDPOINTS.BM_PROJECTS_LIST_FOR_MATERIALS_COST- did not exist - changed toENDPOINTS.BM_PROJECTS)projectId/projectName- changed to_id/nameto match actual API response)issueCharts.css,DarkMode.css,autoComplete.css) that pointed to deleted or non-existent filesStyling
word-break: break-word, deprecated@document, invalidprefers-contrast: highCode quality
typeattributes, array index keys, mutating.sort()replaced with.toSorted(), optional chaining, unused imports, nested ternaries,.removeChildreplaced with.remove()ToolStatusDonutChartcognitive complexity from 25 to under 15 by extractinggetChartDimensions,NoDataView, andDonutChartViewTests
TotalMaterialCostPerProject.test.jsxnow passLeaderboard.test.jsxpassHow to test
shravan-fix-conflicts-4351npm installandnpm run start:localbmdashboard/totalconstructionsummaryvid.mov