Skip to content

Shravan taking over for Carlos - optimize dark mode total construction summary - #4351

Closed
sircarmart wants to merge 34 commits into
developmentfrom
carlos-optimize-dark-mode-total-construction-summary
Closed

Shravan taking over for Carlos - optimize dark mode total construction summary#4351
sircarmart wants to merge 34 commits into
developmentfrom
carlos-optimize-dark-mode-total-construction-summary

Conversation

@sircarmart

Copy link
Copy Markdown
Contributor

Description

image image

Related PRS (if any):

This frontend pr is not related to a backend pr

Main changes explained:

Modified src\components\BMDashboard\WeeklyProjectSummary\WeeklyProjectSummary.jsx and components found within the page

How to test:

  1. check into current branch
  2. do yarn install and yarn start:local to run this PR locally
  3. Clear site data/cache
  4. log as admin user
  5. go to bmdashboard/totalconstructionsummary
  6. verify dark mode was applied to page

Screenshots or videos of changes:

image image

@netlify

netlify Bot commented Nov 7, 2025

Copy link
Copy Markdown

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit ea3abf8
🔍 Latest deploy log https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/6920ab68affb29000834a474
😎 Deploy Preview https://deploy-preview-4351--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@sircarmart sircarmart added the do not review Do not review or look at code without full context label Nov 8, 2025
@sonarqubecloud

Copy link
Copy Markdown

@sircarmart sircarmart removed the do not review Do not review or look at code without full context label Nov 21, 2025

@Anusha-Gali Anusha-Gali left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Carlos,

I have reviewed your PR locally and though the page is dark mode enabled but there are few charts, calendar and their dropdown as well. And am unable to edit the calendar too.
Screenshot 2026-01-12 at 11 25 05 PM
Screenshot 2026-01-12 at 11 25 11 PM
Screenshot 2026-01-12 at 11 25 14 PM
Screenshot 2026-01-12 at 11 25 24 PM
Screenshot 2026-01-12 at 11 25 32 PM
Screenshot 2026-01-12 at 11 25 42 PM
Screenshot 2026-01-12 at 11 25 47 PM
Screenshot 2026-01-12 at 11 25 58 PM
Screenshot 2026-01-12 at 11 26 12 PM
Screenshot 2026-01-12 at 11 26 18 PM
Screenshot 2026-01-12 at 11 26 34 PM
Screenshot 2026-01-12 at 11 26 44 PM

Note: Do let me know if they aren't a part of the PR

@rohanrastogi311 rohanrastogi311 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Carlos,

Well done with this implementation. (Not sure if it's part of scope but some small sub-tabs need modification with dark mode).

PR 4351 Screenshot

@one-community one-community changed the title Carlos - optimize dark mode total construction summary Shravan taking over for Carlos - optimize dark mode total construction summary Apr 5, 2026
@one-community

Copy link
Copy Markdown
Member

Hey Carlos,

Well done with this implementation. (Not sure if it's part of scope but some small sub-tabs need modification with dark mode).

PR 4351 Screenshot

yes, this needs to be fixed as part of this PR

@one-community

Copy link
Copy Markdown
Member

Redone with: #4954

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants