Extract teleop ROS publication builders#779
Conversation
Move root-command, msgpack, and TF construction out of TeleopRos2Node so publisher methods only perform ROS side effects.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThe teleop ROS2 message layer now provides builders that return ROS-native outputs, including msgpack-encoded Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant TeleopROS2Node
participant messages
participant ROS2Topics
TeleopROS2Node->>messages: build controller, EE, body, head, or root outputs
messages-->>TeleopROS2Node: return ROS messages and transforms
TeleopROS2Node->>ROS2Topics: publish returned outputs
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Description
Move root-command, msgpack, and TF construction out of TeleopRos2Node so publisher methods only perform ROS side effects.
Summary by CodeRabbit
New Features
Tests
Documentation