[TeleViz] video-file replay source, XR-default display, and camera-streaming doc overhaul#766
Merged
Conversation
Contributor
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughAdds a GPU-backed Estimated code review effort: 4 (Complex) | ~60 minutes Sequence Diagram(s)sequenceDiagram
participant Config as YAML configuration
participant CameraViz as camera_viz
participant VideoSource as VideoFileSource
participant OpenCV
participant GPU
Config->>CameraViz: load video source and resolve path
CameraViz->>VideoSource: construct source
VideoSource->>OpenCV: probe and decode frames
VideoSource->>GPU: upload and convert frames
GPU-->>CameraViz: provide rendered frame
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/source/references/camera_streaming.rst`:
- Around line 237-243: Correct the stereo example by changing the `stereo` field
in the camera streaming configuration from `false` to `true`, so it matches the
documented per-eye capture and SBS output behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 88f3b110-2f84-476a-bfd9-e27270278655
⛔ Files ignored due to path filters (1)
examples/camera_viz/test_data/recording.mp4is excluded by!**/*.mp4
📒 Files selected for processing (20)
.gitattributesdocs/source/references/camera_streaming.rstexamples/camera_viz/.gitignoreexamples/camera_viz/README.mdexamples/camera_viz/camera_streamer.pyexamples/camera_viz/camera_viz.pyexamples/camera_viz/camera_viz.shexamples/camera_viz/configs/dellwebcam.yamlexamples/camera_viz/configs/multi_camera.yamlexamples/camera_viz/configs/oakd.yamlexamples/camera_viz/configs/realsense.yamlexamples/camera_viz/configs/synthetic.yamlexamples/camera_viz/configs/v4l2.yamlexamples/camera_viz/configs/video.yamlexamples/camera_viz/configs/zed.yamlexamples/camera_viz/pyproject.tomlexamples/camera_viz/sources/__init__.pyexamples/camera_viz/sources/video_file.pyexamples/camera_viz/tests/pyproject.tomlexamples/camera_viz/tests/test_video_file_source.py
💤 Files with no reviewable changes (1)
- examples/camera_viz/configs/dellwebcam.yaml
Play a recording through the FrameSource contract so Televiz can be tested and previewed without camera hardware. Decode via OpenCV's FFmpeg backend on the v4l2 hot path (pinned staging, async H2D, GPU BGR→RGBA); monotonic-deadline pacing at the file's native FPS (or a YAML override); loops by default, holds the last frame otherwise. stereo: true splits side-by-side recordings into per-eye halves on the GPU (viewer-only, like SyntheticStereoSource). width/height are optional — the file is probed at build time — so plane aspect and encoder/sender geometry now come from the built source's spec instead of the YAML. Relative path: values resolve against the config's directory in both entry points. Also works as camera_streamer's capture side (mono), exercising the full NVENC → RTP chain camera-free; verified end-to-end offscreen render + a 30 fps RTP send on hardware. Signed-off-by: Farbod Motlagh <fmotlagh@nvidia.com>
…o replay Reorder the page in test order: requirements → setup → a no-camera first run (video replay, with the exact expected terminal output) → real cameras → XR → split mode → configuration → troubleshooting. Video replay is now the featured hardware-free entry point; synthetic is demoted to a note and table row calling it a render-path debugging tool. Split mode gains a warning that its extra NVENC/NVDEC hop adds latency and that direct mode is preferred whenever the camera can attach to the viewer machine. Supporting changes: camera_viz now raises a clear error when source: rtp entries omit width/height (previously a bare KeyError — video configs make those keys optional); video.yaml documents where the ffmpeg test clip lands; a camera_viz .gitignore keeps generated / user-supplied clips out of git. Signed-off-by: Farbod Motlagh <fmotlagh@nvidia.com>
XR is the product experience, so it becomes the default everywhere: the code default when a config omits display.mode, and the shipped configs' explicit value. camera_viz.sh run already forwarded extra args to camera_viz.py — document --mode xr|window in the usage text and examples so the desktop-window fallback is discoverable. Reframe the camera-streaming doc for public developers (it read like an internal QA script): soften the walkthrough framing, present the first run with both the XR default and the --mode window fallback, fold the XR section into a Display modes section, and add an XR- runtime-missing troubleshooting entry. Signed-off-by: Farbod Motlagh <fmotlagh@nvidia.com>
Device-specific duplicate of v4l2.yaml; nothing referenced it. Signed-off-by: Farbod Motlagh <fmotlagh@nvidia.com>
configs/video.yaml now points at test_data/recording.mp4 (10 s testsrc2 pattern, ~1 MB) so the hardware-free first run works straight after clone — no ffmpeg step. Track *.mp4 via LFS in .gitattributes, carve the test_data exception out of the camera_viz .gitignore, and document the git lfs pull recovery in troubleshooting. Signed-off-by: Farbod Motlagh <fmotlagh@nvidia.com>
…ndow as debug aids Signed-off-by: Farbod Motlagh <fmotlagh@nvidia.com>
Point system requirements at /references/requirements and the XR prerequisites (CloudXR server, headset connection) at the quick-start step anchors instead of restating them. Setup now says explicitly that the pip-install step from the quick start isn't needed — the sample's setup script creates its own environment. Signed-off-by: Farbod Motlagh <fmotlagh@nvidia.com>
Expand the setup flags into a table explaining what each one does (semantics verified against _install_deps.sh). Trim the first-run section: drop the LFS/OpenCV asides and the synthetic note, keeping just 'set a custom path for your own video'. Drop the redundant third requirements bullet, reword '``cameras:``' prose to 'the cameras list', and state that loopback is a testing/debugging aid. Signed-off-by: Farbod Motlagh <fmotlagh@nvidia.com>
…plit-mode one-liners Signed-off-by: Farbod Motlagh <fmotlagh@nvidia.com>
… stream to where Isaac Teleop runs Signed-off-by: Farbod Motlagh <fmotlagh@nvidia.com>
…ases Signed-off-by: Farbod Motlagh <fmotlagh@nvidia.com>
Signed-off-by: Farbod Motlagh <fmotlagh@nvidia.com>
Signed-off-by: Farbod Motlagh <fmotlagh@nvidia.com>
tengw-nv
reviewed
Jul 10, 2026
jiwenc-nv
approved these changes
Jul 10, 2026
farbod-nv
force-pushed
the
fm/recorded_source
branch
from
2194621 to
26df443
Compare
…test Address MR review: 'video' was too generic a config name — rename to replay.yaml and update all references (docs, README, camera_viz.sh). Clarify the stereo comment/doc: side-by-side replay renders as stereo in direct mode only (the RTP sender rejects single-source stereo). Also fix a Windows CI failure in test_resolve_video_paths: a POSIX '/abs' string isn't absolute on Windows and got re-anchored to the drive. Build the absolute test input from tmp_path so it's absolute on any OS. Signed-off-by: Farbod Motlagh <fmotlagh@nvidia.com>
farbod-nv
force-pushed
the
fm/recorded_source
branch
from
ca40809 to
165e77c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds type: video to camera_viz — a hardware-free replay source that plays any recording through the same source → QuadLayer → Televiz path a live camera uses. A sample clip ships via Git LFS and
configs/video.yaml points at it, so the sample works straight after clone: ./camera_viz.sh run configs/video.yaml. Supports looping, FPS pacing, resizing, and side-by-side stereo splitting; also
works as camera_streamer.py's capture side to exercise the NVENC → RTP path camera-free. Covered by 7 tests (clips synthesized in tmpdir, no fixtures).
XR is now the default display mode (code default + shipped configs), with run CONFIG --mode window as the documented desktop fallback.
The camera-streaming doc is restructured for public developers: requirements/setup defer to the system-requirements and quick-start pages, a no-camera first run leads, video replay and window mode
are framed as debug aids, and split mode carries a "not recommended in most cases" warning explaining its extra encode/decode hop. Also: setup-flag reference table, troubleshooting section, clearer error when source: rtp omits width/height, and the unused dellwebcam config removed.
Summary by CodeRabbit
New Features
Bug Fixes
Documentation
Chores