Skip to content

fix(release): fall back when minisign apt package is unavailable #1759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wgqqqqq merged 1 commit into from
Jul 25, 2026
+18 −1
Merged

fix(release): fall back when minisign apt package is unavailable #1759

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/desktop-package.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,6 +324,9 @@ jobs:
--repo "GCWing/BitFun" \
--out linux-release-assets/linux-binaries.json

- name: Setup Rust toolchain (minisign fallback)
uses: dtolnay/rust-toolchain@stable

# The Tauri bundler signs the five updater artifacts during `tauri build`,
# but the installers people download by hand from the release page — dmg,
# deb, rpm, the Windows installer and the direct AppImages — shipped with
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/nightly.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,6 +279,9 @@ jobs:
--repo "GCWing/BitFun" \
--out linux-release-assets/linux-binaries.json

- name: Setup Rust toolchain (minisign fallback)
uses: dtolnay/rust-toolchain@stable

# The Tauri bundler signs the five updater artifacts during `tauri build`,
# but the installers people download by hand from the release page — dmg,
# deb, rpm, the Windows installer and the direct AppImages — shipped with
Expand Down
13 changes: 12 additions & 1 deletion scripts/sign-release-assets.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,18 @@ fi

if ! command -v minisign >/dev/null 2>&1; then
echo "[sign] Installing minisign..."
sudo apt-get install -y --no-install-recommends minisign >/dev/null
# Ubuntu's package is not available in the default repositories on every
# runner image (notably ubuntu-24.04-arm). Prefer it when present, then use
# the portable Rust distribution as a fallback.
if ! sudo apt-get install -y --no-install-recommends minisign >/dev/null 2>&1; then
if ! command -v cargo >/dev/null 2>&1; then
echo "[sign] ERROR: minisign is unavailable and cargo is not installed." >&2
exit 1
fi
MINISIGN_ROOT="${RUNNER_TEMP:-${TMPDIR:-/tmp}}/bitfun-minisign"
cargo install --registry crates-io --locked --root "$MINISIGN_ROOT" minisign >/dev/null
export PATH="$MINISIGN_ROOT/bin:$PATH"
fi
fi

WORK="$(mktemp -d)"
Expand Down