fix(release): fall back when minisign apt package is unavailable#1759
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
minisignwith Cargo when the runner apt repository does not provide itminisignnor Cargo is availableThis fixes signed Linux archive publishing on
ubuntu-24.04-arm, whereapt-get install minisigncurrently fails withUnable to locate package minisign. Fork builds without signing secrets continue to skip signing as before.Verification
bash -n scripts/sign-release-assets.shpnpm run check:github-confignode --test scripts/relay/package-contract.test.mjs scripts/check-github-config.test.mjsgit diff --check