[No QA] Docs updates for E/A#99132 expense type, reimbursable status, and card feed name - #99802
Draft
MelvinBot wants to merge 1 commit into
Draft
[No QA] Docs updates for E/A#99132 expense type, reimbursable status, and card feed name#99802MelvinBot wants to merge 1 commit into
MelvinBot wants to merge 1 commit into
Conversation
…on the expense view Co-authored-by: Mukhriddin Shakhriyorov <mukhrr@users.noreply.github.com>
53 tasks
Contributor
|
A preview of your ExpensifyHelp changes have been deployed to https://50486e74.helpdot.pages.dev ⚡️ Updated articles: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Documentation-only follow-up for #99132, which changed what the expense details show in New Expensify.
Nothing on the help site described the single-expense detail view, so no article stated the old behavior — these are gaps rather than corrections. Two articles are updated:
docs/articles/new-expensify/reports-and-expenses/Managing-Expenses-in-a-Report.mdThis article already ends its expense table section with "Clicking a row opens the full expense details in a side panel (web) or details screen (mobile)" but never said what those details contain. Two new sections pick up from there:
Amount • [expense type] • [reimbursable status]label, lists the expense types, notes that the reimbursable status now shows both Reimbursable and Non-reimbursable (previously only the non-reimbursable case appeared) and only on single-expense reports, and documents Purchase [amount] and Converted [amount] now appearing on their own line under the Amount row instead of inline.{feed name} - {last four}instead of the masked card number, that a custom feed name is used when set, and that the workspace Company cards list is unaffected.internalScopewas also added to the front matter, which the article was missing.docs/articles/new-expensify/connect-credit-cards/Configure-Company-Card-Settings.mdAdds one sentence under the Card feed name setting explaining that this name now surfaces on each imported expense, since that is the setting admins use to control the new label.
Verification
Label text was verified against the live web UI rather than inferred from the diff:
•(U+2022,CONST.DOT_SEPARATOR), not·— byte-checked againstsrc/CONST/index.ts.Amount • Cash • Reimbursable, andAmount • Cash • Non-reimbursableafter toggling the Reimbursable switch off.Expense type strings were taken from
getDetailedExpenseTypeTranslationKeyandsrc/languages/en.ts: Cash, Distance, Per diem, Time, Pending, Expensify Card, Company card, Personal card, Travel Card. TheVisa cards - 1234example matches thegetCommercialFeedCardDescriptionunit test.The feed settings page itself could not be reached in the test environment — Add cards requires a magic-code account validation step, so the Card feed name label is sourced from the existing article rather than re-verified live.
Applied
docs/HELPSITE_NAMING_CONVENTIONS.md,docs/HELP_AUTHORING_GUIDELINES.md, anddocs/TEMPLATE.md: all new headings are##, task-based and start with a question word, UI labels are bolded and match the UI exactly, and the single cross-link uses a relative path with descriptive anchor text.Fixed Issues
$ #98913
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
Not applicable — documentation-only change.
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@mukhrr, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.