Show expense type and commercial card feed name on the expense view

[mukhrr]

Explanation of Change

Adds expense type (Cash/Card/Distance/etc) next to Amount, shows reimbursable state on both sides, moves Purchase/Converted underneath as a hint, and shows {feed name} - {last4} instead of the masked PAN for commercial card feed (VCF/CDF/GL1025) cards.

Fixed Issues

$ #98913
PROPOSAL: #98913 (comment)

Tests

1. Open an expense report with one manual (cash) expense.
2. On the expense view, confirm the Amount field subtitle reads Amount · Cash · Reimbursable (or · Non-reimbursable if the toggle is off).
3. Toggle Reimbursable on/off and confirm the label updates.
4. Open an expense imported from a company card where the purchase amount differs from the posted amount.
5. Confirm Purchase [amount] now shows as its own line under the Amount row, not inline in the Amount · ... subtitle.
6. Open a foreign-currency expense (not card-imported) on a report in a different currency, confirm Converted [amount] shows under the Amount row the same way.
7. Open a Distance, Per Diem, or Time expense and confirm the Amount subtitle shows the correct type (Distance, Per diem, Time), not Cash.
8. On a workspace with a commercial card feed connected (Visa/Mastercard/Amex, VCF/CDF/GL1025) and an imported transaction, open that expense's view and confirm the Card field shows {feed name} - {last four} (e.g. Visa cards - 1234), not the masked card number.
9. If the admin set a custom nickname for that feed (Workspace Settings > Company Cards > feed settings), confirm the Card field shows the nickname instead.
10. Go to Workspace Settings > Company Cards and confirm the card list there still shows the masked PAN, unchanged.
11. Repeat steps 1-3 on a report with multiple expenses and confirm no Reimbursable/Non-reimbursable label appears (unchanged, single-expense-report only).

• Verify that no errors appear in the JS console

Offline tests

Same as tests, no network calls involved.

QA Steps

Same as tests.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

ios_app.mp4

Android: mWeb Chrome

android_web.mp4

iOS: Native

ios_app.mp4

iOS: mWeb Safari

ios_web.mp4

MacOS: Chrome / Safari

web.mp4

[melvin-bot]

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[codecov]

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...mponents/TransactionItemRow/DataCells/TypeCell.tsx	75.60% <ø> (+0.13%)	⬆️
src/libs/CardUtils.ts	85.76% <100.00%> (+34.35%)	⬆️
src/libs/TransactionUtils/index.ts	91.58% <100.00%> (+0.83%)	⬆️
...c/components/ReportActionItem/MoneyRequestView.tsx	77.27% <87.50%> (+0.10%)	⬆️
... and 236 files with indirect coverage changes

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 14a3be4141

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[trjExpensify]

@joekaufmanexpensify Flavia is out this week, would you be up for swapping in on the product review?

[joekaufmanexpensify]

yep!

[dubielzyk-expensify]

Videos are looking neat to me. When adhoc is ready I'll test on my account to see how it looks with currency conversion etc.

[github-actions]

🚧 joekaufmanexpensify has triggered a test Expensify/App build. You can view the workflow run here.

[mukhrr]

@ZhenjaHorbach kindly bump

[dubielzyk-expensify]

This was the case I was curious about but it doesn't look terrible. A bit verbose but until we do bigger changes I think this is fine.

[ZhenjaHorbach]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
• I verified tests pass on all platforms & I tested again on:
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

2026-08-26.15.24.59.mov

Android: mWeb Chrome

2026-08-26.15.22.30.mov

iOS: HybridApp

2026-08-26.15.20.23.mov

iOS: mWeb Safari

2026-08-26.15.17.27.mov

MacOS: Chrome / Safari

2026-08-26.15.09.17.mov

[ZhenjaHorbach]

LGTM!

[joekaufmanexpensify]

Commercial card stuff looks good to me

[joekaufmanexpensify]

I did notice an issue with currency on the ad hoc build. I'm seeing undefined in the currency selector when creating a workspace and can't change currency when creating an expense. Not happening on staging. Do we think that this is related to the PR?

Adhoc

Staging

[ZhenjaHorbach]

I'm not sure that it's related to this PR since we didn't touch this code
@mukhrr
But let's update the branch to the latest version of main
And then run an adhoc build again

[mukhrr]

checking 👀

[mukhrr]

@joekaufmanexpensify @ZhenjaHorbach I think this is pre-existing bug. I can reproduce on stagin as well

REC-20260826214022.mp4

RCA

Offending PR: #9607 "Refactor GetLocalCurrency" (luacmartins, merged 2022-07-16), commit 2b281f6740d.

That PR deleted PersonalDetails.getCurrencyList() and, with it, the on-demand fetch in both currency-consuming pages:

// IOUCurrencySelection.js and WorkspaceSettingsPage.js — both removed
-    componentDidMount() { this.fetchData(); }
-    componentDidUpdate(prevProps) {
-        if (!prevProps.network.isOffline || this.props.network.isOffline) { return; }
-        this.fetchData();            // ← re-fetch when coming back online
-    }
-    fetchData() { PersonalDetails.getCurrencyList(); }

That was the self-heal path. After it, OpenApp is the only source of currencyList.

The chain:

1. currencyList has no FE writer — 4 references in src/, all reads.
2. OpenApp carries it; ReconnectApp does not. Measured on both dev and staging:

Command	carries currencyList
OpenApp	yes — jsonCode 200, 167 currencies, USD.symbol = "$"
ReconnectApp	no

3. AuthScreensInitHandler.tsx:185-188 calls openApp() only when didUserLogInDuringSession(). That flag is false whenever session.authToken is already persisted at boot (SessionUtils.ts:81) — i.e. every boot after the first sign-in. So it's reconnectApp().
4. Since Refactor GetLocalCurrency #9607 removed the on-demand fetch, nothing ever backfills it. The key is unrecoverable once missing.
5. CurrencySelector.tsx:85 renders `${currency} - ${getCurrencySymbol(currency)}` → USD - undefined, and the picker list renders empty.

So i think this is out of scope and we can fix as a follow up? what do you think guys?

[ZhenjaHorbach]

It's not our issue😁
So we can just ignore this

[mukhrr]

@ZhenjaHorbach I mean I am interested in a follow up issue, haha

[joekaufmanexpensify]

Okay, sounds good. Yeah, I agree we do not need to handle here then.

[joekaufmanexpensify]

Good for product.

[github-actions]

🚧 arosiclair has triggered a test Expensify/App build. You can view the workflow run here.

[mukhrr]

@joekaufmanexpensify @ZhenjaHorbach I think this is pre-existing bug. I can reproduce on stagin as well

REC-20260826214022.mp4

RCA

Offending PR: #9607 "Refactor GetLocalCurrency" (luacmartins, merged 2022-07-16), commit 2b281f6740d.

That PR deleted PersonalDetails.getCurrencyList() and, with it, the on-demand fetch in both currency-consuming pages:

// IOUCurrencySelection.js and WorkspaceSettingsPage.js — both removed
-    componentDidMount() { this.fetchData(); }
-    componentDidUpdate(prevProps) {
-        if (!prevProps.network.isOffline || this.props.network.isOffline) { return; }
-        this.fetchData();            // ← re-fetch when coming back online
-    }
-    fetchData() { PersonalDetails.getCurrencyList(); }

That was the self-heal path. After it, OpenApp is the only source of currencyList.

The chain:

1. currencyList has no FE writer — 4 references in src/, all reads.
2. OpenApp carries it; ReconnectApp does not. Measured on both dev and staging:

Command carries currencyList
OpenApp yes — jsonCode 200, 167 currencies, USD.symbol = "$"
ReconnectApp no
3. AuthScreensInitHandler.tsx:185-188 calls openApp() only when didUserLogInDuringSession(). That flag is false whenever session.authToken is already persisted at boot (SessionUtils.ts:81) — i.e. every boot after the first sign-in. So it's reconnectApp().
4. Since Refactor GetLocalCurrency #9607 removed the on-demand fetch, nothing ever backfills it. The key is unrecoverable once missing.
5. CurrencySelector.tsx:85 renders `${currency} - ${getCurrencySymbol(currency)}` → USD - undefined, and the picker list renders empty.

So i think this is out of scope and we can fix as a follow up? what do you think guys?

@joekaufmanexpensify @arosiclair do we want to fix this as a follow up?

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #99132.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-1b39932-9586fa8-9704a3f8741c3764d9100123415df66bee0d9159/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-1b39932-9586fa8-a5ea42942d045612bb9c9b95ae6a5ac7324b281e/index.html

Web 🕸️
https://99132.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[ZhenjaHorbach]

@joekaufmanexpensify @ZhenjaHorbach I think this is pre-existing bug. I can reproduce on stagin as well
REC-20260826214022.mp4

RCA

Offending PR: #9607 "Refactor GetLocalCurrency" (luacmartins, merged 2022-07-16), commit 2b281f6740d.
That PR deleted PersonalDetails.getCurrencyList() and, with it, the on-demand fetch in both currency-consuming pages:

// IOUCurrencySelection.js and WorkspaceSettingsPage.js — both removed
-    componentDidMount() { this.fetchData(); }
-    componentDidUpdate(prevProps) {
-        if (!prevProps.network.isOffline || this.props.network.isOffline) { return; }
-        this.fetchData();            // ← re-fetch when coming back online
-    }
-    fetchData() { PersonalDetails.getCurrencyList(); }

That was the self-heal path. After it, OpenApp is the only source of currencyList.
The chain:

1. currencyList has no FE writer — 4 references in src/, all reads.
2. OpenApp carries it; ReconnectApp does not. Measured on both dev and staging:

Command carries currencyList
OpenApp yes — jsonCode 200, 167 currencies, USD.symbol = "$"
ReconnectApp no
3. AuthScreensInitHandler.tsx:185-188 calls openApp() only when didUserLogInDuringSession(). That flag is false whenever session.authToken is already persisted at boot (SessionUtils.ts:81) — i.e. every boot after the first sign-in. So it's reconnectApp().
4. Since Refactor GetLocalCurrency #9607 removed the on-demand fetch, nothing ever backfills it. The key is unrecoverable once missing.
5. CurrencySelector.tsx:85 renders `${currency} - ${getCurrencySymbol(currency)}` → USD - undefined, and the picker list renders empty.
So i think this is out of scope and we can fix as a follow up? what do you think guys?

@joekaufmanexpensify @arosiclair do we want to fix this as a follow up?

Do we have a stable way to reproduce this without clearing the cache in offline mode?

[OSBotify]

🚀 Deployed to staging by https://github.com/arosiclair in version: 9.4.64-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[MelvinBot]

Yes — help site changes are required. Draft PR: #99802

Two behaviors this PR changed are user-visible and were not documented anywhere under docs/articles:

1. The Amount row label now reads Amount • [expense type] • [reimbursable status], and the reimbursable status now shows both states instead of only Non-reimbursable. Purchase and Converted moved to their own line under the Amount row.
2. Commercial card feed expenses now show {feed name} - {last four} on the Card row instead of the masked card number.

What I changed and why

No article documented the single-expense detail view at all, so nothing on the help site stated the old behavior — these are gaps to fill, not corrections.

docs/articles/new-expensify/reports-and-expenses/Managing-Expenses-in-a-Report.md — this article already ends its expense table section with "Clicking a row opens the full expense details in a side panel (web) or details screen (mobile)" and then stops, so it is the natural home. Added two sections:

• What the Amount row shows in the expense details
• What the Card row shows on an imported card expense

Also added the missing internalScope front matter, which HELP_AUTHORING_GUIDELINES.md requires.

docs/articles/new-expensify/connect-credit-cards/Configure-Company-Card-Settings.md — one sentence under the Card feed name setting, since that is the setting admins use to control the new expense label.

Verified against the live web UI, not inferred from the diff:

Check	Status	Observation
Amount row subtitle, default state	pass	Exactly Amount • Cash • Reimbursable — separator is • (U+2022), not ·. Byte-checked against CONST.DOT_SEPARATOR.
Amount row subtitle, Reimbursable off	pass	Exactly Amount • Cash • Non-reimbursable; reverts on toggling back on
Reimbursable toggle row label	pass	Exactly Reimbursable
Expense detail row labels, top to bottom	pass	Receipt, Amount, Description, Merchant, Date, Category, Reimbursable, Report (Tag/Billable/Tax/Attendees/Card absent — those workspace features were off on the fresh test workspace)
Workspace settings menu item for company cards	pass	Exactly Company cards
Card feed name setting label	partial	Could not reach it — Add cards requires a magic-code account validation step the test account can't clear. Label sourced from the existing article instead.

Expense type strings came from getDetailedExpenseTypeTranslationKey and src/languages/en.ts: Cash, Distance, Per diem, Time, Pending, Expensify Card, Company card, Personal card, Travel Card. The Visa cards - 1234 example matches the getCommercialFeedCardDescription unit test in this PR.

One item I could not complete: GitHub rejected assigning the docs PR to mukhrr (Reviews may only be requested from collaborators / assignee silently dropped) because that account has read access to Expensify/App, not write. The HelpDot label is applied and the PR body @-mentions you, so you will still be notified. An Expensify engineer with write access can add the assignee if it is needed.

@mukhrr, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review

---

view run

[mukhrr]

Do we have a stable way to reproduce this without clearing the cache in offline mode?

@ZhenjaHorbach I think no