Skip to content

Docs updates for E/A#98963 Pay button now always prompts for payment method - #99800

Draft
MelvinBot wants to merge 1 commit into
mainfrom
claude-docsPaySplitButtonRemoval
Draft

Docs updates for E/A#98963 Pay button now always prompts for payment method#99800
MelvinBot wants to merge 1 commit into
mainfrom
claude-docsPaySplitButtonRemoval

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

#98963 removed the split behavior from the Pay button. The button no longer pre-selects the payment method you used last time, no longer shows that method as a subtitle, and no longer has a separate dropdown segment. Selecting Pay now always opens the payment method menu.

docs/articles/new-expensify/wallet-and-payments/Pay-Expenses.md documented the old behavior in both the Workspace and personal payment flows, telling members that "your most recent payment method will appear automatically" and to "tap the right side of the button to see all available options." Those steps now describe a UI that does not exist, so this PR rewrites them.

Content changes

  • Removed the two steps in each flow that described the remembered payment method and the right-side dropdown.
  • Replaced them with a single step: select Pay, then choose a method from the menu that opens.
  • Named the menu options using the labels in the product: Pay with business account, Pay with wallet, and Mark as paid.
  • Added a lead paragraph and an FAQ entry explaining that Expensify asks every time, so members who remember the old behavior are not left looking for a setting.
  • Rewrote the closing FAQ answer that referenced the "Pay button dropdown."

Verified against the live UI by driving dev NewDot on web: created a workspace, submitted and approved an expense, and confirmed the report header and the report preview both render a single Pay €25.00 button with no dropdown segment, and that selecting it opens a menu containing Pay with business account and Mark as paid.

Structural changes required by docs/HELP_AUTHORING_GUIDELINES.md, which allows exactly one # heading plus # FAQ. The article had three # headings and no title heading. Demoted the section headings to ##, added the # title matching the front matter, and made each heading task-based.

One thing needs a human: the screenshot docs/assets/images/Reports_PayExpense_02_Update.png shows the removed split button — a green Pay $14.62 pill with a "Bank account • 1234" subtitle and a chevron segment. I removed the image reference and left a <!-- SCREENSHOT: --> placeholder describing the replacement to capture. Someone with access to the asset pipeline should shoot and add the new image.

Fixed Issues

$ #98663
PROPOSAL:

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@bernhardoj, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

Co-authored-by: Bernhard Owen Josephus <bernhardoj@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team August 28, 2026 21:51
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Aug 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants