Docs updates for E/A#98963 Pay button now always prompts for payment method - #99800
Draft
MelvinBot wants to merge 1 commit into
Draft
Docs updates for E/A#98963 Pay button now always prompts for payment method#99800MelvinBot wants to merge 1 commit into
MelvinBot wants to merge 1 commit into
Conversation
Co-authored-by: Bernhard Owen Josephus <bernhardoj@users.noreply.github.com>
40 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
#98963 removed the split behavior from the Pay button. The button no longer pre-selects the payment method you used last time, no longer shows that method as a subtitle, and no longer has a separate dropdown segment. Selecting Pay now always opens the payment method menu.
docs/articles/new-expensify/wallet-and-payments/Pay-Expenses.mddocumented the old behavior in both the Workspace and personal payment flows, telling members that "your most recent payment method will appear automatically" and to "tap the right side of the button to see all available options." Those steps now describe a UI that does not exist, so this PR rewrites them.Content changes
Verified against the live UI by driving dev NewDot on web: created a workspace, submitted and approved an expense, and confirmed the report header and the report preview both render a single Pay €25.00 button with no dropdown segment, and that selecting it opens a menu containing Pay with business account and Mark as paid.
Structural changes required by
docs/HELP_AUTHORING_GUIDELINES.md, which allows exactly one#heading plus# FAQ. The article had three#headings and no title heading. Demoted the section headings to##, added the#title matching the front matter, and made each heading task-based.One thing needs a human: the screenshot
docs/assets/images/Reports_PayExpense_02_Update.pngshows the removed split button — a green Pay $14.62 pill with a "Bank account • 1234" subtitle and a chevron segment. I removed the image reference and left a<!-- SCREENSHOT: -->placeholder describing the replacement to capture. Someone with access to the asset pipeline should shoot and add the new image.Fixed Issues
$ #98663
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@bernhardoj, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.