Improvement: Mesh handle tutorials - #2348
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2348 +/- ##
=======================================
Coverage 82.36% 82.36%
=======================================
Files 125 125
Lines 20708 20708
=======================================
Hits 17056 17056
Misses 3652 3652 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
lenaploetzke
left a comment
There was a problem hiding this comment.
Partial review. Thank you for your work, this is really nice and my comments are mainly documentation! :)
Co-authored-by: lenaploetzke <70579874+lenaploetzke@users.noreply.github.com>
lenaploetzke
left a comment
There was a problem hiding this comment.
Review adapt callback file
|
Could you please have a look at the failing workflows? |
lenaploetzke
left a comment
There was a problem hiding this comment.
Most things are just typos and capitalization.
Co-authored-by: lenaploetzke <70579874+lenaploetzke@users.noreply.github.com>
| int rank = 0; | ||
| MPI_Comm_rank (comm, &rank); | ||
| if (rank == 0) { | ||
| std::cout << "=== " << stage << " ===" << std::endl; | ||
| std::cout << "Total elements: " << global_elements << std::endl; | ||
| } |
There was a problem hiding this comment.
Yeah i know, but some pverhead here. get_num_global_elements is merged now so you are ready to use it here :)
|
|
||
| /** Build our adapted mesh by transferring the adaption parameters and adapting once with our \ref adapt_callback function. | ||
| * \tparam TMeshClass The mesh handle class. | ||
| * \param sc_MPI_Comm The MPI Communicator. |
There was a problem hiding this comment.
| * \param sc_MPI_Comm The MPI Communicator. | |
| * \param comm The MPI Communicator. |
| auto mesh = build_mesh<mesh_type> (comm, uniform_level); | ||
| /* Write the mesh to a vtu file. */ | ||
| t8_global_productionf (" [t8 step 3 Mesh handle] \n"); | ||
| t8_global_productionf (" [t8 step 3 Mesh handle] Writing adapted mesh to vtu file: step3_adapted_mesh.vtu\n"); |
There was a problem hiding this comment.
Would be better to introduce a variable for the name and reusing it! That way if you change the name, you do not have to change it everywhere :)
Describe your changes here:
All these boxes must be checked by the AUTHOR before requesting review:
Documentation:,Bugfix:,Feature:,Improvement:orOther:.All these boxes must be checked by the REVIEWERS before merging the pull request:
As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.
General
Tests
If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):
Scripts and Wiki
scripts/internal/find_all_source_files.shto check the indentation of these files.License
doc/(or already has one).