feat(maf): consolidate refresh stack on current main#17
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4894ebf56e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| findings.extend(check_bare_except(diff_file.path, diff_file.added_lines)) | ||
| findings.extend(check_missing_telemetry(diff_file.path, diff_file.added_lines)) |
There was a problem hiding this comment.
Restrict Python exception checks to Python files
When the critic is run on a docs-only diff that adds a fenced Python example containing except Exception:, this loop still sends that Markdown file through check_bare_except and produces a blocking finding even though no executable Python changed. Limit the exception/telemetry checks to Python source paths so documentation or wiki updates cannot fail the critic gate for illustrative snippets.
Useful? React with 👍 / 👎.
Summary
Consolidate the surviving autogen refresh work onto current
mainwithout reintroducing the stale dependency snapshot from the older PR stack.Changes
mainWhy
autogenstill had several open PRs that became stale aftermainmoved forward. Those branches carried useful code and docs, but they also carried an outdated dependency snapshot that was failing CI and conflicting with the current branch head. This PR replaces that stale stack with one verified branch built on currentmain.Validation
python -m pytest tests/test_contract_compatibility.py -q --tb=short -spython -m pytest tests/test_critic.py tests/test_provider_fallback_telemetry.py tests/test_worker_boundary.py -q --tb=short -spython -m compileall autogen_starter autogen_dashboard maf_starter main.py -qnode --check autogen_dashboard/static/app.jsagent_framework,agent_framework_devui, andagent_framework_orchestrationsinside the repo-local.venvRisks
maf_starter/provider_fallback.py,maf_starter/critic.py, and.github/workflows/pytest -qpath still is not a reliable gate in this environment due to a capture/collection issue, so validation is intentionally targetedRelated
Reviewer notes
Start with the runtime changes under
maf_starter/, then the workflow hardening in.github/workflows/, then the refreshed docs.