Skip to content

feat(29-01): deterministic peer critic pattern-scan engine#14

Closed
OgeonX-Ai wants to merge 1 commit into
mainfrom
feat/phase-29-peer-critic
Closed

feat(29-01): deterministic peer critic pattern-scan engine#14
OgeonX-Ai wants to merge 1 commit into
mainfrom
feat/phase-29-peer-critic

Conversation

@OgeonX-Ai

Copy link
Copy Markdown
Contributor

Summary

  • Adds maf_starter/critic.py: a zero-config, deterministic Resilience First pattern checker (bare-except detection, missing-telemetry detection, file-size-limit check) returning a structured CriticReport with a BLOCKING vs ADVISORY severity split.
  • Adds maf_starter/critic_cli.py: a runnable local entrypoint (python -m maf_starter.critic_cli --diff <path|-> [--severity-gate blocking|advisory]) that exits non-zero on BLOCKING findings by default.
  • Implements REQ-1.4.5 (Peer Critic Pattern) as a standalone, reusable module -- intentionally not wired into the existing SpecialistRole roster to avoid destabilizing the typed sequential pipeline.

Test plan

  • python -m pytest tests/test_critic.py -v -- 13/13 passing (dirty-diff-blocks, clean-diff-passes, malformed-input-never-crashes, CLI exit codes)
  • python -m maf_starter.critic_cli --help confirms module entrypoint with --diff and --severity-gate
  • Live evidence run against this org's own PR feat(28-02): structured JSON failure telemetry + CLI fallback size guards #12 diff (feat(28-02): structured JSON failure telemetry + CLI fallback size guards): critic: 0 blocking, 1 advisory, exit code 0 -- demonstrates the BLOCKING/ADVISORY split does not false-positive-block a real, already-merged-quality PR.

🤖 Generated with Claude Code

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@OgeonX-Ai

Copy link
Copy Markdown
Contributor Author

Superseded by #17, which consolidated the surviving work onto current main without reintroducing the stale dependency stack.

@OgeonX-Ai OgeonX-Ai closed this Jul 8, 2026
auto-merge was automatically disabled July 8, 2026 18:32

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant