feat(29-01): deterministic peer critic pattern-scan engine#14
Closed
OgeonX-Ai wants to merge 1 commit into
Closed
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
2 tasks
Contributor
Author
|
Superseded by #17, which consolidated the surviving work onto current main without reintroducing the stale dependency stack. |
auto-merge was automatically disabled
July 8, 2026 18:32
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
maf_starter/critic.py: a zero-config, deterministic Resilience First pattern checker (bare-except detection, missing-telemetry detection, file-size-limit check) returning a structuredCriticReportwith a BLOCKING vs ADVISORY severity split.maf_starter/critic_cli.py: a runnable local entrypoint (python -m maf_starter.critic_cli --diff <path|-> [--severity-gate blocking|advisory]) that exits non-zero on BLOCKING findings by default.SpecialistRoleroster to avoid destabilizing the typed sequential pipeline.Test plan
python -m pytest tests/test_critic.py -v-- 13/13 passing (dirty-diff-blocks, clean-diff-passes, malformed-input-never-crashes, CLI exit codes)python -m maf_starter.critic_cli --helpconfirms module entrypoint with--diffand--severity-gatefeat(28-02): structured JSON failure telemetry + CLI fallback size guards):critic: 0 blocking, 1 advisory, exit code 0 -- demonstrates the BLOCKING/ADVISORY split does not false-positive-block a real, already-merged-quality PR.🤖 Generated with Claude Code