Skip to content

Birmingham|26-ITP-May|Yonas Gebre|Sprint 1|Form Control #1264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yonasdesbelegebre wants to merge 9 commits into
base: main
Choose a base branch
from
+131 −13
Open

Birmingham|26-ITP-May|Yonas Gebre|Sprint 1|Form Control #1264

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
778e937
the html format only
haftomprogrammer May 13, 2026
304b08c
Style added for the forms
yonasdesbelegebre May 13, 2026
c70d30f
modify the name label
yonasdesbelegebre May 13, 2026
2f0ee3b
color performance optimization
yonasdesbelegebre May 14, 2026
f409355
add div for labels
yonasdesbelegebre May 16, 2026
55ffbef
modified the form color and perofrmance desktop
yonasdesbelegebre May 22, 2026
a82cab3
modifed feedbacks
yonasdesbelegebre May 29, 2026
1bcb7c1
email includes more characters
yonasdesbelegebre May 29, 2026
df00e2f
radio button error
yonasdesbelegebre May 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Form-Controls/README.md
View file
Open in desktop
Copy link
Copy Markdown

@Luro91 Luro91 May 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are there changes in this file? How is it related to the task?

Copy link
Copy Markdown
Author

@yonasdesbelegebre yonasdesbelegebre May 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, could you make it clear. Did you need more explanation about the code.

Copy link
Copy Markdown

@Luro91 Luro91 Jun 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You commited some change to Form-Controls/README.md which I don't understand.

Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,8 @@ Let's write out our testable criteria. Check each one off as you complete it.

> Before you say you're done: Is your code readable? Does it run correctly? Does it look professional?

These practices reflect the level of quality expected in professional work.
These practices reflect the level of quality expected in professiona- [MDN: Form validation](https://developer.mozilla.org/en-US/docs/Learn/Forms/Form_validation)
l work.
They ensure your code is reliable, maintainable, and presents a polished, credible experience to users.

- [ ] My HTML code has no errors or warnings when validated using https://validator.w3.org/
Expand All @@ -61,7 +62,6 @@ They ensure your code is reliable, maintainable, and presents a polished, credib

## Resources
- [MDN: Form controls](https://developer.mozilla.org/en-US/docs/Learn/Forms)
- [MDN: Form validation](https://developer.mozilla.org/en-US/docs/Learn/Forms/Form_validation)
- [Lighthouse](https://developers.google.com/web/tools/lighthouse)
- [Lighthouse](https://developers.google.comcom/web/tools/lighthouse)
- [Lighthouse Guide](https://programming.codeyourfuture.io/guides/testing/lighthouse)
- [Format Code and Make Logical Commits in VS Code](../practical_guide.md)
64 changes: 54 additions & 10 deletions Form-Controls/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="utf-8" />
<meta http-equiv="X-UA-Compatible" content="IE=edge" />
<link rel="stylesheet" href="style.css" >
<meta charset="utf-8" >
<meta http-equiv="X-UA-Compatible" content="IE=edge" >
<title>My form exercise</title>
<meta name="description" content="" />
<meta name="description" content="The page Contains Form to submit customer information about T-shirts" />
<meta name="viewport" content="width=device-width, initial-scale=1" />
</head>
<body>
Expand All @@ -13,15 +14,58 @@ <h1>Product Pick</h1>
</header>
<main>
<form>
<!-- write your html here-->
<!--
try writing out the requirements first as comments
this will also help you fill in your PR message later-->
</form>
</main>
<!-- -->
<div>
<label for="customername">Customer name *: </label>
<input type="text" id="customername" name="customername" required
pattern="^[A-Za-z]{2,}$"
Copy link
Copy Markdown

@Luro91 Luro91 Jun 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not allow special characters like the German ä,ü,ö or Russian ед

placeholder="Customer name"/>
</div>

<div>
<label for="customeremail">Customer email: </label>
<input type="email" id="customeremail" name="customeremail" required
pattern="^[\p{L}\p{N}._%+-]+@[\p{L}\p{N}.-]+\.[\p{L}]{2,}$"
placeholder="Customer email" />
</div>

<div>
<label>T-shirt color *:</label>
<div class="control">
<label class="t-color">
<input type="radio" name="color" value="Black" required/>
Black
</label>
<label class="t-color">
<input type="radio" name="color" value="Red" required/>
Red
</label>
<label class="t-color">
<input type="radio" name="color" value="Blue" required/>
Blue
</label>
</div>
</div>
<div>
<label>T-shirt size *:</label>
<select name="sizes" id="sizes" required>
<option value="" disabled selected>Select size</option>
<option value="xs">XS</option>
<option value="s">S</option>
<option value="m">M</option>
<option value="l">L</option>
<option value="xL">XL</option>
<option value="xxL">XXL</option>
</select>
</div>
<div>
<button type="submit" id="submit">Submit</button>
</div>
</form>
</main>
<footer>
<!-- change to your name-->
<p>By HOMEWORK SOLUTION</p>
<p>By Yonas Gebre</p>
</footer>
</body>
</html>
74 changes: 74 additions & 0 deletions Form-Controls/style.css
View file
Open in desktop
Copy link
Copy Markdown

@Luro91 Luro91 May 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job that you separated the CSS into its own file—that’s an excellent best practice and will make your code much easier to read, debug, and maintain as it grows.

Original file line number Diff line number Diff line change
@@ -0,0 +1,74 @@
/* body style */
input:valid{
border:2px solid yellow;
}
input:invalid:not(:placeholder-shown){
border:2px solid red;
}
body {
background-color: lightwhite;
max-width: 800px;
display: flex;
flex-direction: column;
align-items: center;
padding: 25px;
}

header h1 {
color: #2c3e50;
margin-bottom: 15px;
}

form {
background: skyblue;
padding: 30px;
border-radius: 8px;
box-shadow: 0 4px 15px rgba(0, 0, 0, 0.1);
width: 100%;
max-width: 400px;
}
input:focus {
border-color: #3498db;
outline: none;
}
/* Labels and Inputs */
label {
display: block;
margin-top: 15px;
margin-bottom: 5px;
font-weight: 600;
font-size: 0.9rem;
}

input[type="text"],
input[type="email"],
select,button {
align-items: right;
width: 100%;
padding: 10px;
border: 2px solid #ddd;
border-radius: 6px;
box-sizing: border-box; /* Ensures padding doesn't break width */
transition: border-color 0.3s ease;
}

.radio {
display: flex;
align-items: center;
gap: 5px;
font-weight: normal;
}
#submit {
background-color: #3498db;
margin-top: 15px;
border: none;
cursor: pointer;
font-size: 1rem;
}

/* Footer */
footer {
margin-top: 20px;
font-size: 0.8rem;
color:black;
}
Loading