Birmingham|26-ITP-May|Yonas Gebre|Sprint 1|Form Control#1264
Birmingham|26-ITP-May|Yonas Gebre|Sprint 1|Form Control#1264yonasdesbelegebre wants to merge 9 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
yonasdesbelegebre
added
the
Needs Review
Luro91
added
the
Review in progress
There was a problem hiding this comment.
Good job that you separated the CSS into its own file—that’s an excellent best practice and will make your code much easier to read, debug, and maintain as it grows.
There was a problem hiding this comment.
Why are there changes in this file? How is it related to the task?
There was a problem hiding this comment.
sorry, could you make it clear. Did you need more explanation about the code.
There was a problem hiding this comment.
You commited some change to Form-Controls/README.md which I don't understand.
Luro91
added
Reviewed
yonasdesbelegebre
left a comment
yonasdesbelegebre
left a comment
There was a problem hiding this comment.
I have learned more about how to validate and clean my code, thank you for your feedback.
yonasdesbelegebre
added
Needs Review
Luro91
left a comment
Luro91
left a comment
There was a problem hiding this comment.
I get an Accessibility score of 89 in Lighthouse. How can you get it to 100?
| <div> | ||
| <label for="customername">Customer name *: </label> | ||
| <input type="text" id="customername" name="customername" required | ||
| pattern="^[A-Za-z]{2,}$" |
There was a problem hiding this comment.
This does not allow special characters like the German ä,ü,ö or Russian ед
There was a problem hiding this comment.
You commited some change to Form-Controls/README.md which I don't understand.
Luro91
added
Reviewed
3 participants
Learners, PR Template
Self checklist
Changelist
The form collects customer names and email addresses, as well as t-shirt sizes and colors.
The inputs are all required.
For customer names, it is only possible to use characters.
For the email, I use a regular expression.
For t-shirt colors, there are 3 available choices as radio type with colors black, red, and blue.
For T-shirt , i use select one from the list of 6 sizes.
Styles for the form and elements.